[action logs] Add action log plugin library class#22389
Merged
mbabker merged 3 commits intojoomla:stagingfrom Oct 6, 2018
Merged
[action logs] Add action log plugin library class#22389mbabker merged 3 commits intojoomla:stagingfrom
mbabker merged 3 commits intojoomla:stagingfrom
Conversation
mbabker
reviewed
Sep 26, 2018
plugins/actionlog/joomla/joomla.php
Outdated
| use Joomla\CMS\Component\ComponentHelper; | ||
| use Joomla\Utilities\ArrayHelper; | ||
|
|
||
| JLoader::import('com_actionlogs.libraries.actionlogplugin', JPATH_ADMINISTRATOR . '/components'); |
Contributor
There was a problem hiding this comment.
Use JLoader::register() the same way that is done for the privacy plugins please.
mbabker
reviewed
Sep 26, 2018
| $messages[$index] = $message; | ||
| } | ||
|
|
||
| /* @var ActionlogsModelActionlog $model */ |
Contributor
There was a problem hiding this comment.
Should be /** @var ... for IDEs to correctly pick up this inline doc block. Otherwise it's just seen as a "normal" comment.
Member
Author
There was a problem hiding this comment.
In PHPStorm it works also with one *. But I will change it. There are more places to cleanup then.
Member
Author
|
Done the changes. |
Contributor
|
I have tested this item ✅ successfully on d48be2f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22389. |
Member
|
I have tested this item ✅ successfully on d48be2f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22389. |
Member
|
RTC. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22389. |
Member
|
Note: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
As extension dev, I like to do as less repetitive work as possible. This pr adds a base class extension devs can use to log actions more convenient. For example a plugin can then look like:
Additionally it simplifies the default Joomla log plugin.
Testing Instructions
Save an article.
Expected result
An action log is created.
Actual result
An action log is created.
Documentation Changes Required
Document that a base class exists.