Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty trees #4010

Merged
merged 7 commits into from
Apr 18, 2019
Merged

Allow empty trees #4010

merged 7 commits into from
Apr 18, 2019

Conversation

youri-k
Copy link
Contributor

@youri-k youri-k commented Apr 11, 2019 •
edited by fm3
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • create a nml with an empty tree
  • upload nml -> tree should be visible
  • download annotation -> nml should contain tree

Issues:

@youri-k youri-k self-assigned this Apr 11, 2019
@youri-k youri-k requested a review from fm3 April 11, 2019 15:16
@youri-k youri-k changed the title allow empty trees Allow empty trees Apr 11, 2019
fm3
fm3 approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

please add a changelog entry
also, one optimization: the Some() in line 257 is redundant with the flatMap around it, can be cleaned up :)

@youri-k youri-k merged commit 62128f3 into master Apr 18, 2019
hotzenklotz added a commit that referenced this pull request Apr 18, 2019
@hotzenklotz
Merge branch 'doc_update' of github.com:scalableminds/webknossos into…
17074d8 
… doc_update

* 'doc_update' of github.com:scalableminds/webknossos:
  Fix sitemap for publication detail view (#4024)
  Add sitemap.xml (#4006)
  Allow empty trees  (#4010)
hotzenklotz added a commit that referenced this pull request Apr 25, 2019
@hotzenklotz
Merge branch 'master' into mobile
f9bd0f4 
* master: (43 commits)
  update screenshots (#4038)
  docker: don't set sbt/ivy cache (#4034)
  Slow down brush size change for small sizes (#4012)
  voulme tool bar now depends only on the active tool (#4029)
  Allow user to adapt GPU memory consumption to allow for better quality (#4015)
  Updates the Docs (#4020)
  hiding pricing and features in iframe (#4019)
  Fix sitemap for publication detail view (#4024)
  Add sitemap.xml (#4006)
  Allow empty trees  (#4010)
  Prefer annotation zoom over dataset zoom (#3992)
  Add details view for publications (#3994)
  remove enzyme test (#3997)
  Tensorflow segmentation (#3461)
  ensure that max zoom step is not exceeded when changing viewport area (#3996)
  allow isosurfaces for hybrid tracings when setting window.allowIsosurfaces (#3998)
  re-fetch buckets if fetching them failed (#3999)
  Only re-compute bounding sphere of skeletons if something changed (#3995)
  Fix dropdown login padding (#3988)
  Persist tree visibility (#3942)
  ...
@normanrz normanrz deleted the empty-tree-support branch August 12, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 approved these changes

Assignees

@youri-k youri-k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Empty Trees
2 participants
@youri-k @fm3