Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details view for publications #3994

Merged
merged 8 commits into from
Apr 11, 2019

Conversation

MichaelBuessemeyer
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer commented Apr 5, 2019

This PR adds a view for each publication at /publication/<publication_id>. This page can be accessed via a link in the spotlight view's publication cards. The link is next to the title of the publication and is only visible when the title is hovered.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Enable the fontendpage in the features (appplication.conf) and just open the spotlight view.
  • From there select on of the publications link to its own view.
  • From the "detailed" view you can go back by using the icon next to "Back".
  • This should work for each publication.

Issues:


@MichaelBuessemeyer MichaelBuessemeyer self-assigned this Apr 5, 2019
@MichaelBuessemeyer MichaelBuessemeyer changed the title [WIP] Add details view for publications Add details view for publications Apr 5, 2019
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, code looks good, UI, too 👍

One thing, though:

image

Can you ensure that the arrow and the "back" text are vertically aligned?

frontend/javascripts/dashboard/publication_details_view.js Outdated Show resolved Hide resolved
@MichaelBuessemeyer MichaelBuessemeyer merged commit 2f97e47 into master Apr 11, 2019
hotzenklotz added a commit that referenced this pull request Apr 25, 2019
* master: (43 commits)
  update screenshots (#4038)
  docker: don't set sbt/ivy cache (#4034)
  Slow down brush size change for small sizes (#4012)
  voulme tool bar now depends only on the active tool (#4029)
  Allow user to adapt GPU memory consumption to allow for better quality (#4015)
  Updates the Docs (#4020)
  hiding pricing and features in iframe (#4019)
  Fix sitemap for publication detail view (#4024)
  Add sitemap.xml (#4006)
  Allow empty trees  (#4010)
  Prefer annotation zoom over dataset zoom (#3992)
  Add details view for publications (#3994)
  remove enzyme test (#3997)
  Tensorflow segmentation (#3461)
  ensure that max zoom step is not exceeded when changing viewport area (#3996)
  allow isosurfaces for hybrid tracings when setting window.allowIsosurfaces (#3998)
  re-fetch buckets if fetching them failed (#3999)
  Only re-compute bounding sphere of skeletons if something changed (#3995)
  Fix dropdown login padding (#3988)
  Persist tree visibility (#3942)
  ...
@philippotto philippotto deleted the add-details-view-for-publications branch May 20, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve SEO for finding individual datasets / publications
3 participants