Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that max zoom step is not exceeded when changing viewport area #3996

Merged
merged 2 commits into from
Apr 9, 2019
Merged

Ensure that max zoom step is not exceeded when changing viewport area #3996

merged 2 commits into from
Apr 9, 2019

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Apr 8, 2019 •
edited by daniel-wer
Loading

I also added some validations to avoid NaN as zoomStep.

URL of deployed dev instance (used for testing):

Steps to test:

  • zoom out as far as possible
  • hit . to maximize current pane
  • zoom step should be adapted automatically so that max zoom step is not exceeded

Issues:

@philippotto philippotto self-assigned this Apr 8, 2019
@philippotto philippotto requested a review from daniel-wer April 8, 2019 13:44
daniel-wer
daniel-wer approved these changes Apr 8, 2019
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant fix :)

Slightly related, I noticed during testing that when maximizing the YZ viewport (and that one only) one can zoom out too much. I was using the dsa2 dataset on the dev server. Maybe there's an easy fix, otherwise we'll create an issue for that:
zoom-y-z-bug

@philippotto philippotto mentioned this pull request Apr 9, 2019
Closed
@philippotto philippotto merged commit acb4b77 into master Apr 9, 2019
hotzenklotz added a commit that referenced this pull request Apr 25, 2019
@hotzenklotz
Merge branch 'master' into mobile
f9bd0f4 
* master: (43 commits)
  update screenshots (#4038)
  docker: don't set sbt/ivy cache (#4034)
  Slow down brush size change for small sizes (#4012)
  voulme tool bar now depends only on the active tool (#4029)
  Allow user to adapt GPU memory consumption to allow for better quality (#4015)
  Updates the Docs (#4020)
  hiding pricing and features in iframe (#4019)
  Fix sitemap for publication detail view (#4024)
  Add sitemap.xml (#4006)
  Allow empty trees  (#4010)
  Prefer annotation zoom over dataset zoom (#3992)
  Add details view for publications (#3994)
  remove enzyme test (#3997)
  Tensorflow segmentation (#3461)
  ensure that max zoom step is not exceeded when changing viewport area (#3996)
  allow isosurfaces for hybrid tracings when setting window.allowIsosurfaces (#3998)
  re-fetch buckets if fetching them failed (#3999)
  Only re-compute bounding sphere of skeletons if something changed (#3995)
  Fix dropdown login padding (#3988)
  Persist tree visibility (#3942)
  ...
@philippotto philippotto deleted the adapt-zoom-on-viewport-change branch May 20, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Max zoom value constraint is not enforced in all scenarios
2 participants
@philippotto @daniel-wer