Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow isosurfaces for hybrid tracings when setting flag #3998

Merged
merged 2 commits into from
Apr 9, 2019

Conversation

philippotto
Copy link
Member

For demo/screenshot this can be useful (@normanrz). Hidden behind window.allowIsosurfaces since the UX is not smooth right now (isosurface is only calculated using the segmentation layer and active cell can only be changed in brush/trace mode).

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • set window.allowIsosurfaces to true
  • change some settings, so that these are re-rendered and reveal the isosurface option
  • select brush or trace tool
  • select active cell with shift + click

Issues:


  • Ready for review

@philippotto philippotto self-assigned this Apr 8, 2019
@philippotto philippotto requested a review from daniel-wer April 8, 2019 15:03
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@philippotto philippotto merged commit e8672c6 into master Apr 9, 2019
hotzenklotz added a commit that referenced this pull request Apr 25, 2019
* master: (43 commits)
  update screenshots (#4038)
  docker: don't set sbt/ivy cache (#4034)
  Slow down brush size change for small sizes (#4012)
  voulme tool bar now depends only on the active tool (#4029)
  Allow user to adapt GPU memory consumption to allow for better quality (#4015)
  Updates the Docs (#4020)
  hiding pricing and features in iframe (#4019)
  Fix sitemap for publication detail view (#4024)
  Add sitemap.xml (#4006)
  Allow empty trees  (#4010)
  Prefer annotation zoom over dataset zoom (#3992)
  Add details view for publications (#3994)
  remove enzyme test (#3997)
  Tensorflow segmentation (#3461)
  ensure that max zoom step is not exceeded when changing viewport area (#3996)
  allow isosurfaces for hybrid tracings when setting window.allowIsosurfaces (#3998)
  re-fetch buckets if fetching them failed (#3999)
  Only re-compute bounding sphere of skeletons if something changed (#3995)
  Fix dropdown login padding (#3988)
  Persist tree visibility (#3942)
  ...
@philippotto philippotto deleted the allow-iso-in-hybrid branch May 20, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants