Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropdown login padding #3988

Merged
merged 10 commits into from
Apr 8, 2019
Merged

Fix dropdown login padding #3988

merged 10 commits into from
Apr 8, 2019

Conversation

MichaelBuessemeyer
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer commented Apr 4, 2019

This PR adds a margin between the forgot password and Register Now in the login dropdown and thus ensures some space between them. I also made the position of the dropdown fixed so that it does not scroll away anymore.

URL of deployed dev instance (used for testing):

Steps to test:

  • logout and open the dropdown. Resize the window and try to get the two options forgot password and Register Now together. There should be at least some space between them.
  • Testing that the dropdown does not scroll away: add some margin-bottom to the main container so that it becomes scrollable :)

Issues:


@philippotto
Copy link
Member

Thanks for doing this and also for implementing the fixed fix :)

I noticed, that it can happen that the links are not next to each other when resizing the window. You can enforce the correct layout, by using a flexbox. The markdown should look something like this:

// warning: this is not jsx but html
<div style="display: flex;">
  <a href="/auth/register" style="margin-right: 10px; flex-grow: 1;">Register Now</a>
  <a href="/auth/resetPassword">Forgot Password</a>
</span>

@MichaelBuessemeyer
Copy link
Contributor Author

@philippotto nice notice 👍 , but the changes you suggested do not fix this problem for me. But let's talk about this together 🙂

@MichaelBuessemeyer
Copy link
Contributor Author

@philippotto I updated the dev instance with your suggested changes. They seem to work but I think the solution is not ideal, as the links now get displayed like a table 😕

@philippotto
Copy link
Member

@philippotto I updated the dev instance with your suggested changes. They seem to work but I think the solution is not ideal, as the links now get displayed like a table

Thank you! I just added white-space: nowrap; to the two a elements. Let's hope, this works :)

@MichaelBuessemeyer
Copy link
Contributor Author

@philippotto I updated the dev instance and your fix works perfectly 👍

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@philippotto philippotto merged commit 45b98ab into master Apr 8, 2019
hotzenklotz added a commit that referenced this pull request Apr 25, 2019
* master: (43 commits)
  update screenshots (#4038)
  docker: don't set sbt/ivy cache (#4034)
  Slow down brush size change for small sizes (#4012)
  voulme tool bar now depends only on the active tool (#4029)
  Allow user to adapt GPU memory consumption to allow for better quality (#4015)
  Updates the Docs (#4020)
  hiding pricing and features in iframe (#4019)
  Fix sitemap for publication detail view (#4024)
  Add sitemap.xml (#4006)
  Allow empty trees  (#4010)
  Prefer annotation zoom over dataset zoom (#3992)
  Add details view for publications (#3994)
  remove enzyme test (#3997)
  Tensorflow segmentation (#3461)
  ensure that max zoom step is not exceeded when changing viewport area (#3996)
  allow isosurfaces for hybrid tracings when setting window.allowIsosurfaces (#3998)
  re-fetch buckets if fetching them failed (#3999)
  Only re-compute bounding sphere of skeletons if something changed (#3995)
  Fix dropdown login padding (#3988)
  Persist tree visibility (#3942)
  ...
@philippotto philippotto deleted the fix-dropdown-login-issue branch May 20, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login dropdown layout issue
2 participants