-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dropdown login padding #3988
Conversation
…ver is no longer scrolled away
Thanks for doing this and also for implementing the I noticed, that it can happen that the links are not next to each other when resizing the window. You can enforce the correct layout, by using a flexbox. The markdown should look something like this:
|
@philippotto nice notice 👍 , but the changes you suggested do not fix this problem for me. But let's talk about this together 🙂 |
@philippotto I updated the dev instance with your suggested changes. They seem to work but I think the solution is not ideal, as the links now get displayed like a table 😕 |
Thank you! I just added |
@philippotto I updated the dev instance and your fix works perfectly 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
* master: (43 commits) update screenshots (#4038) docker: don't set sbt/ivy cache (#4034) Slow down brush size change for small sizes (#4012) voulme tool bar now depends only on the active tool (#4029) Allow user to adapt GPU memory consumption to allow for better quality (#4015) Updates the Docs (#4020) hiding pricing and features in iframe (#4019) Fix sitemap for publication detail view (#4024) Add sitemap.xml (#4006) Allow empty trees (#4010) Prefer annotation zoom over dataset zoom (#3992) Add details view for publications (#3994) remove enzyme test (#3997) Tensorflow segmentation (#3461) ensure that max zoom step is not exceeded when changing viewport area (#3996) allow isosurfaces for hybrid tracings when setting window.allowIsosurfaces (#3998) re-fetch buckets if fetching them failed (#3999) Only re-compute bounding sphere of skeletons if something changed (#3995) Fix dropdown login padding (#3988) Persist tree visibility (#3942) ...
This PR adds a margin between the
forgot password
andRegister Now
in the login dropdown and thus ensures some space between them. I also made the position of the dropdown fixed so that it does not scroll away anymore.URL of deployed dev instance (used for testing):
Steps to test:
forgot password
andRegister Now
together. There should be at least some space between them.margin-bottom
to the main container so that it becomes scrollable :)Issues:
[ ] Updated changelog[ ] Updated migration guide if applicable[ ] Updated documentation if applicable[ ] Adapted wk-connect if datastore API changes[ ] Needs datastore update after deployment