-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tensorflow segmentation #3461
Tensorflow segmentation #3461
Conversation
…bknossos into tensorflow-segmentation
…bknossos into tensorflow-segmentation
* [WIP] provide sampled mean and stdev for color layer data * convert to unsigned, clean up * best resolution is actually min, not max * pretty-backend
…bknossos into tensorflow-segmentation
…bknossos into tensorflow-segmentation
…bknossos into tensorflow-segmentation
…bknossos into tensorflow-segmentation-webworker
@philippotto I'd say this is ready for a first review round. I cannot assign you as a reviewer, because you originally created this PR ^^ I'm especially looking for ways to improve the code in the I've also updated the PR description and listed the remaining ToDos, feel free to add more stuff there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍 The code looks really good. I left some suggestions/questions.
Also, I'd suggest to extract the entire infer-saga into an own file. Then, the helper functions within that saga can also be extracted to the top-level so that the main saga is not so long :)
@@ -36,6 +37,9 @@ import Model from "oxalis/model"; | |||
import Store from "oxalis/store"; | |||
import * as Utils from "libs/utils"; | |||
|
|||
// TODO later remove me | |||
window.isMagicWandToolEnabled = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder to set this to false.
@philippotto I've finished up my Todos, maybe you could have another look at the code and do a final test run? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Code refactoring looks very good 👍 Testing worked well, too. Only thing, I noticed is that the auto-annotation stops if I'm moving too fast along the w direction (e.g., z). I thought you said that this wouldn't happen? However, I'm fine with this.
You can approve this PR now ^^ I can't because I created it.
frontend/javascripts/oxalis/model/sagas/automatic_brush_saga.js
Outdated
Show resolved
Hide resolved
…ization, make floodfill_threshold configurable
Yes that's what I thought, but it does indeed stop if the user moves too far ahead. Let's rethink what should happen if the user moves too far away while using the auto brush as part of the next iteration :) |
* master: (43 commits) update screenshots (#4038) docker: don't set sbt/ivy cache (#4034) Slow down brush size change for small sizes (#4012) voulme tool bar now depends only on the active tool (#4029) Allow user to adapt GPU memory consumption to allow for better quality (#4015) Updates the Docs (#4020) hiding pricing and features in iframe (#4019) Fix sitemap for publication detail view (#4024) Add sitemap.xml (#4006) Allow empty trees (#4010) Prefer annotation zoom over dataset zoom (#3992) Add details view for publications (#3994) remove enzyme test (#3997) Tensorflow segmentation (#3461) ensure that max zoom step is not exceeded when changing viewport area (#3996) allow isosurfaces for hybrid tracings when setting window.allowIsosurfaces (#3998) re-fetch buckets if fetching them failed (#3999) Only re-compute bounding sphere of skeletons if something changed (#3995) Fix dropdown login padding (#3988) Persist tree visibility (#3942) ...
Open Issues:
URL of deployed dev instance (used for testing):
Steps to test:
Ctrl + Click
on a segment to trigger the Magic Wand. A toast should open and inform you of the process.Alt
in any mode to move the viewport in a photoshop-like manner.Issues:
- [ ] Updated changelog- [ ] Updated migration guide if applicable