Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sitemap.xml #4006

Merged
merged 8 commits into from
Apr 18, 2019
Merged

Add sitemap.xml #4006

merged 8 commits into from
Apr 18, 2019

Conversation

youri-k
Copy link
Contributor

@youri-k youri-k commented Apr 11, 2019

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • request [...]/sitemap.xml and look for right sitemap

Issues:


  • Ready for review

@youri-k youri-k requested a review from fm3 April 11, 2019 11:52
@youri-k youri-k self-assigned this Apr 11, 2019
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. Nice XML streaming :)
Please make sure that this is only served on the demo instance (might be a good opportunity to introduce corresponding boolean in the features block of the config, preparing for the upcoming #4008)

Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youri-k youri-k merged commit dd02d5d into master Apr 18, 2019
@fm3 fm3 deleted the add-sitemap branch April 18, 2019 09:46
hotzenklotz added a commit that referenced this pull request Apr 18, 2019
… doc_update

* 'doc_update' of github.com:scalableminds/webknossos:
  Fix sitemap for publication detail view (#4024)
  Add sitemap.xml (#4006)
  Allow empty trees  (#4010)
hotzenklotz added a commit that referenced this pull request Apr 25, 2019
* master: (43 commits)
  update screenshots (#4038)
  docker: don't set sbt/ivy cache (#4034)
  Slow down brush size change for small sizes (#4012)
  voulme tool bar now depends only on the active tool (#4029)
  Allow user to adapt GPU memory consumption to allow for better quality (#4015)
  Updates the Docs (#4020)
  hiding pricing and features in iframe (#4019)
  Fix sitemap for publication detail view (#4024)
  Add sitemap.xml (#4006)
  Allow empty trees  (#4010)
  Prefer annotation zoom over dataset zoom (#3992)
  Add details view for publications (#3994)
  remove enzyme test (#3997)
  Tensorflow segmentation (#3461)
  ensure that max zoom step is not exceeded when changing viewport area (#3996)
  allow isosurfaces for hybrid tracings when setting window.allowIsosurfaces (#3998)
  re-fetch buckets if fetching them failed (#3999)
  Only re-compute bounding sphere of skeletons if something changed (#3995)
  Fix dropdown login padding (#3988)
  Persist tree visibility (#3942)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sitemap
2 participants