Add release notes for 0.231#13997
Conversation
91011c3 to
8425385
Compare
|
No release note for #13155 |
8425385 to
0564e23
Compare
rschlussel
left a comment
There was a problem hiding this comment.
Please make sure to follow the order of sections and changes within sections that's specified here: https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines
Also, make sure each line ends with a period for consistency.
rongrong
left a comment
There was a problem hiding this comment.
In general check the quoting of variables, properties, keywords, etc.
5a5992f to
53550da
Compare
c73df8e to
0057390
Compare
There was a problem hiding this comment.
LGTM in general! Though I'd trust @rschlussel more than myself. 😛
rschlussel
left a comment
There was a problem hiding this comment.
Basically looks good and I have to head out. @rongrong No need to wait for me to review again before merging.
There was a problem hiding this comment.
I still don't think this is very clear -- what is a partition merging strategy? How would a user decide when to set this property or what the appropriate setting should be?
Or if it's not really user facing, maybe it doesn't need a release note.
There was a problem hiding this comment.
It's a little bit tricky (at least for me) to summarize the change of behavior in a short note. If it's doable, can we keep this note with a link to the PR where I have detailed description on the change of behavior?
Another option is to exclude this note as I can imagine only very sophisticated user will need to leverage it. By default it does not change the current behavior.
There was a problem hiding this comment.
we can probably leave out the note then, but adding a link to a PR or issue is also an option
you can link to an issue or pr using the following syntax as appropriate.
For issue #1234
:issue:`1234`
For pr #1234
:pr:`1234`
0057390 to
ed06650
Compare
ed06650 to
de9385a
Compare
|
Thanks @bhhari i'll merge this once tests pass |
Missing Release Notes
Ariel Weisberg
Ke Wang
Rohit Jain
Saksham Sachdev
ptkool
Extracted Release Notes
LEGACYand can be overwritten toTOP_DOWNorBOTTOM_UP.LINESTRING(0 0, 0 0, 0 0). + Returned WKTs may have a different point order. + Fixes incorrect calculation of extreme points in certain cases.control_session_propertiesandtest_session_propertiestoverifier_queries, and remove columnsession_properties_json. The value of the removed column can be copied to the two new columns for the schema change.max-determinism-analysis-runsto control maximum number of determinism analysis runs in case of column mismatch.run-teardown-for-determinism-analysisto allow disabling teardown for determinism analysis runs.cache.base-directory.All Commits