Keep sum stat for string when min/max stat is too long in ORC writer#13879
Merged
wenleix merged 1 commit intoprestodb:masterfrom Dec 26, 2019
Merged
Keep sum stat for string when min/max stat is too long in ORC writer#13879wenleix merged 1 commit intoprestodb:masterfrom
wenleix merged 1 commit intoprestodb:masterfrom
Conversation
Member
islamismailov
commented
Dec 19, 2019
Member
Author
|
Might need to fully revert this diff, since we do not need to drop min/max to avoid OOMing the verifier anymore: |
e456644 to
2e8272e
Compare
wenleix
approved these changes
Dec 19, 2019
Contributor
wenleix
left a comment
There was a problem hiding this comment.
LGTM.
For the commit message, I would suggest
Keep sum stat for string when min/max stat is too long in ORC writer
2e8272e to
caa5af8
Compare
Member
Author
|
Only those with write access to this repository can merge pull requests.
|
|
Assign to @wenleix to merge |
Contributor
|
Merged #13879. Thanks @islamismailov for the contribution! |
7 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.