Add max buffer size to Raptor session properties#13905
Merged
highker merged 1 commit intoprestodb:masterfrom Dec 31, 2019
jainxrohit:rj_maxbuffer
Merged
Add max buffer size to Raptor session properties#13905highker merged 1 commit intoprestodb:masterfrom jainxrohit:rj_maxbuffer
highker merged 1 commit intoprestodb:masterfrom
jainxrohit:rj_maxbuffer
Conversation
highker
approved these changes
Dec 30, 2019
highker
left a comment
highker
left a comment
There was a problem hiding this comment.
Could you update the commit message to be
Add max buffer size to Raptor session properties
The rule is to limit the #words per line under 72 (incl.) characters.
presto-raptor/src/main/java/com/facebook/presto/raptor/RaptorSessionProperties.java
Outdated
Show resolved
Hide resolved
jainxrohit
changed the title
Contributor
Author
I have fixed both commit message and PR detail. |
Adding max buffer size to raptor session properties in the Raptor page sink provider, earlier it was present in the config.
7 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consuming max buffer size from the session properties instead of configs in the Raptor page sink provider.