Fix invalid plan for repeated lambdas in order by#13901
Merged
rschlussel merged 1 commit intoprestodb:masterfrom Jan 9, 2020
Merged
Fix invalid plan for repeated lambdas in order by#13901rschlussel merged 1 commit intoprestodb:masterfrom
rschlussel merged 1 commit intoprestodb:masterfrom
Conversation
rongrong
reviewed
Jan 8, 2020
Contributor
There was a problem hiding this comment.
Maybe just do
stream(expressionsToRemap)
.forEach(expression -> newBuilder.getTranslations().put(expression, builder.translate(expression)));
I don't have strong opinions. Just that overall the codebase seems to prefer stream API when logic is simple.
rongrong
approved these changes
Jan 8, 2020
Presto was creating invalid plans for queries with duplicate lambda
expressions in the order by clause because the expressions were
considered "equal" for some purposes, but not equal when converting the lambdas
to symbols. This caused one of the expressions to not be mapped to an input
symbol. To resolve this, we don't deduplicate even seemingly equal expressions
in the order by clause so that we maintain translations for all the
expressions.
Example query:
SELECT
COUNT(*)
FROM
(values ARRAY['a', 'b']) as t(col1)
ORDER BY
IF(
SUM(
REDUCE(
col1,
ROW(0),
("l", "r") -> "l",
"x" -> 1
)
) > 0,
COUNT(*),
SUM(
REDUCE(
col1,
ROW(0),
("l", "r") -> "l",
"x" -> 1
)
)
)
0ab8c14 to
0cdbb15
Compare
7 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presto was creating invalid plans for queries with duplicate lambda
expressions in the order by clause because the expressions were
considered "equal" for some purposes, but not equal when converting the lambdas
to symbols. This caused one of the expressions to not be mapped to an input
symbol. To resolve this, we don't deduplicate even seemingly equal expressions
in the order by clause so that we maintain translations for all the
expressions.
Example query:
This fixes the second part of #10694