Skip verification when checksum query fails to compile#13853
Merged
mbasmanova merged 1 commit intoprestodb:masterfrom Dec 12, 2019
Merged
Skip verification when checksum query fails to compile#13853mbasmanova merged 1 commit intoprestodb:masterfrom
mbasmanova merged 1 commit intoprestodb:masterfrom
Conversation
When the target table has too many floating point columns, checksum query ends up with too many columns with window functions, causing COMPILER_FAILURE error code. This case cannot be properly handled by the Verifier and thus should be skipped for now.
mbasmanova
approved these changes
Dec 12, 2019
presto-verifier/src/main/java/com/facebook/presto/verifier/framework/AbstractVerification.java
Show resolved
Hide resolved
mbasmanova
changed the title
7 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the target table has too many floating point columns, checksum
query ends up with too many columns with window functions, causing
COMPILER_FAILURE error code. This case cannot be properly handled by
the Verifier and thus should be skipped for now.