Cherry-pick documentation for cost, statistics, CBO#13155
Merged
rschlussel merged 2 commits intoprestodb:masterfrom Jan 7, 2020
Merged
Cherry-pick documentation for cost, statistics, CBO#13155rschlussel merged 2 commits intoprestodb:masterfrom
rschlussel merged 2 commits intoprestodb:masterfrom
Conversation
arhimondr
approved these changes
Jul 30, 2019
Member
arhimondr
left a comment
arhimondr
left a comment
There was a problem hiding this comment.
LGTM
@rschlussel , could you please also have a look?
presto-docs/src/main/sphinx/optimizer/cost-based-optimizations.rst
Outdated
Show resolved
Hide resolved
presto-docs/src/main/sphinx/optimizer/cost-based-optimizations.rst
Outdated
Show resolved
Hide resolved
rschlussel
reviewed
Jul 30, 2019
presto-docs/src/main/sphinx/optimizer/cost-based-optimizations.rst
Outdated
Show resolved
Hide resolved
presto-docs/src/main/sphinx/optimizer/cost-based-optimizations.rst
Outdated
Show resolved
Hide resolved
presto-docs/src/main/sphinx/optimizer/cost-based-optimizations.rst
Outdated
Show resolved
Hide resolved
presto-docs/src/main/sphinx/optimizer/cost-based-optimizations.rst
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Decision of build and probe side is also done by cost-based join distribution. Cost-based join-enumeration adds the decision of whether to reorder multiple inner joins (if you're joining 3 tables, which 2 get joined first)
Contributor
Author
There was a problem hiding this comment.
Added a line to address this.
presto-docs/src/main/sphinx/optimizer/cost-based-optimizations.rst
Outdated
Show resolved
Hide resolved
presto-docs/src/main/sphinx/optimizer/cost-based-optimizations.rst
Outdated
Show resolved
Hide resolved
aweisberg
force-pushed
the
cherry-pick-127
branch
from
1582d8e to
c2981df
Compare
rschlussel
reviewed
Aug 7, 2019
Contributor
There was a problem hiding this comment.
I think you accidentally deleted the rest of this paragraph. It should be something like
The join distribution type is governed by the ``join_distribution_type``
session property, with the ``join-distribution-type`` configuration
property providing the default value.
Extracted-From: https://github.com/starburstdata/presto Cherry-pick of trinodb/trino#127 Co-authored-by: Ariel Weisberg <aweisberg@fb.com>
aweisberg
force-pushed
the
cherry-pick-127
branch
from
c2981df to
8b771f8
Compare
|
|
aweisberg
force-pushed
the
cherry-pick-127
branch
from
8b771f8 to
823c001
Compare
Extracted-From: https://github.com/starburstdata/presto Cherry-pick of trinodb/trino#127 Co-authored-by: Łukasz Osipiuk <lukasz@osipiuk.net>
aweisberg
force-pushed
the
cherry-pick-127
branch
from
823c001 to
2c7cde3
Compare
rschlussel
approved these changes
Jan 7, 2020
Contributor
|
test failure is a timeout, and this is a pure docs change that's definitely not related. i'll merge without rebuilding. |
7 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of trinodb/trino#127