Fix function namespace manager instantiation failure#13842
Merged
rongrong merged 1 commit intoprestodb:masterfrom Dec 12, 2019
Merged
Fix function namespace manager instantiation failure#13842rongrong merged 1 commit intoprestodb:masterfrom
rongrong merged 1 commit intoprestodb:masterfrom
Conversation
caithagoras
changed the title
rongrong
reviewed
Dec 11, 2019
presto-main/src/main/java/com/facebook/presto/metadata/StaticCatalogStore.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/metadata/StaticFunctionNamespaceStore.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/metadata/FunctionManager.java
Outdated
Show resolved
Hide resolved
Contributor
|
Please fix checkstyle error. |
Function namespace manager name identifies the type (namely, the implementation class) of a function namespace manager. However, it is also incorrectly used as a key to identify instances of function namespace manager. With the fix, the config file name (without the file extention) is used as the instance id.
rongrong
approved these changes
Dec 12, 2019
7 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.