Add caching file system to hive connector#13904
Add caching file system to hive connector#13904highker merged 1 commit intoprestodb:masterfrom jainxrohit:rj_caching_hive
Conversation
presto-hive/src/main/java/com/facebook/presto/hive/HiveClientModule.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HiveClientModule.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HiveClientModule.java
Outdated
Show resolved
Hide resolved
...ptor/src/main/java/com/facebook/presto/raptor/filesystem/RaptorCachingHdfsConfiguration.java
Outdated
Show resolved
Hide resolved
presto-raptor/src/main/java/com/facebook/presto/raptor/filesystem/HdfsModule.java
Outdated
Show resolved
Hide resolved
highker
left a comment
There was a problem hiding this comment.
Could you remove the period in the commit title? https://chris.beams.io/posts/git-commit/ is a good commit message guideline.
Nice article, fixed the commit message. |
presto-hive/src/main/java/com/facebook/presto/hive/CachingFileOpener.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HiveCachingHdfsConfiguration.java
Outdated
Show resolved
Hide resolved
presto-raptor/src/main/java/com/facebook/presto/raptor/filesystem/HdfsModule.java
Outdated
Show resolved
Hide resolved
|
The test failure is due to permission/auth setting. Try overriding the following function in @Override
public void setPermission(Path path, FsPermission permission)
throws IOException
{
dataTier.setPermission(path, permission);
}But in general, I would suggest overriding all default functions from |
presto-cache/src/main/java/com/facebook/presto/cache/CachingFileSystem.java
Outdated
Show resolved
Hide resolved
presto-cache/src/main/java/com/facebook/presto/cache/CachingFileSystem.java
Outdated
Show resolved
Hide resolved
presto-cache/src/main/java/com/facebook/presto/cache/CachingFileSystem.java
Outdated
Show resolved
Hide resolved
presto-cache/src/main/java/com/facebook/presto/cache/CachingFileSystem.java
Outdated
Show resolved
Hide resolved
presto-cache/src/main/java/com/facebook/presto/cache/CachingFileSystem.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HiveCachingHdfsConfiguration.java
Outdated
Show resolved
Hide resolved
presto-cache/src/main/java/com/facebook/presto/cache/CachingFileSystem.java
Outdated
Show resolved
Hide resolved
presto-cache/src/main/java/com/facebook/presto/cache/CachingFileSystem.java
Outdated
Show resolved
Hide resolved
presto-cache/src/main/java/com/facebook/presto/cache/CachingFileSystem.java
Outdated
Show resolved
Hide resolved
presto-cache/src/main/java/com/facebook/presto/cache/CachingFileSystem.java
Outdated
Show resolved
Hide resolved
presto-cache/src/main/java/com/facebook/presto/cache/CachingFileSystem.java
Outdated
Show resolved
Hide resolved
presto-cache/src/main/java/com/facebook/presto/cache/CachingFileSystem.java
Outdated
Show resolved
Hide resolved
presto-cache/src/main/java/com/facebook/presto/cache/CachingFileSystem.java
Outdated
Show resolved
Hide resolved
presto-cache/src/main/java/com/facebook/presto/cache/CachingFileSystem.java
Outdated
Show resolved
Hide resolved
presto-cache/src/main/java/com/facebook/presto/cache/CachingFileSystem.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/CachingFileOpener.java
Outdated
Show resolved
Hide resolved
highker
left a comment
There was a problem hiding this comment.
LGTM. @shixuan-fan, could you give it a final review and merge it?
shixuan-fan
left a comment
There was a problem hiding this comment.
LGTM, ideally we would want to have three commits:
- Fixing caching file system
- Raptor side change
- Hive side change
But since it is already reviewed, I won't bother breaking it down. I'll merge it once we've completed the internal repo pull request that adapt to this one.
Uh oh!
There was an error while loading. Please reload this page.