Merge 20220201 #103
Merged
Merge 20220201 #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an instance type that does not support HyperVGeneration version 1 then terraform returns an error mentioning there's support only for V1. Adding a check during install config to check for the versions supported by the instance type provided.
Run the httpd container after the coreos-downloader completes to ensure that the kernel parameters can be added correctly. Signed-off-by: Zhou Hao <[email protected]>
Add the IP addresses for IBM bootstrap and master nodes to allow collecting of logs from those nodes.
…o wait kube-apiserver rolls out on AlibabaCloud (openshift#5535)" This reverts commit 6e2d76b. With openshift/machine-config-operator#2919, it is no longer necessary to delay the teardown of the bootstrap control plane. The cluster will no longer get into an unusable state when there is only a single kube-apiserver pod running.
The current patch allows the user to specify the content of the install-config networkConfig field directly as a yaml object. Content validation (for a generic yaml) is now carried on by the install config asset
Bug 2037813: [baremetal] networkConfig field now accepts yaml instead of string value
* Update openshift/api to 6e0b1eb97188. * Update kube modules to v0.23.0. * Update controller-runtime to v0.11.0. * Remove unused terraform-provider-kubernetes.
The hack/verify-codegen.sh script was using an image that included go 1.16. However, the updated k8s.io/json module calls the `(reflect.StructField) IsExported` function, which is new in go 1.17. Consequently, the script needs to be updated to use an image that include go 1.17 rather than 1.16.
Bug 2043731: Add IP outputs for IBM terraform instances
Remove hard coding, support users can specify cloud_efficiency in regions that do not support cloud_essd disk category Signed-off-by: sunhui <[email protected]>
If the user chooses a base domain for which there is no zone, creating the A record in the zone is simply skipped rather than raising an error. Signed-off-by: sunhui <[email protected]>
Fix the overlapping problem of the VSwitch subnet of the Nat gateway with the master node VSwitch subnets Signed-off-by: sunhui <[email protected]>
Avoid the issue that ironic agent image cannot be downloaded due to network proxy. Signed-off-by: Zhou Hao <[email protected]>
This reverts commit 2684f8d.
When users use an existing network, no longer create Nat gateways and EIPs Signed-off-by: sunhui <[email protected]>
…s_0.23.0 Bug 2037209: vendor: update openshift/api to latest in preparation for alibaba machine provider changes
This change updates the alibaba provider spec usage related to the vswitch, security groups, and resource group. The API for the provider spec is changing to use a discriminated union to capture the various methods for finding resources (by id, name, or tags). It also updates several machine api references to note the bifurcated nature of the api version between v1beta1 and v1.
This change is to update the vendor references to support the Alibaba resrouce reference updates to the API.
Bug 2037209: update alibaba for provider spec api changes
Fix the reference to an unbound variable; avoid incrementing the invalid certificate counter in a subshell.
…id-cert-script Bug 2038166: openstack: Fix invalid-https-certificate detection
Remove unsupport region Nanjing and Dubai. Signed-off-by: sunhui <[email protected]>
Support internal publish strategy for platform Alibaba Cloud Signed-off-by: sunhui <[email protected]> å
Add NAT gateway validation to check the region whether support NAT gateway Signed-off-by: sunhui <[email protected]>
Should not destroy pre-configured alicloud DNS private zone Signed-off-by: sunhui <[email protected]>
Bug 2045927: Add proxy for ironic-agent.service
Fix resource group ID validation errors caused by pagination issues Signed-off-by: sunhui <[email protected]>
AMIs for GovCloud regions have been added to the RHCOS stream. Remove validation requiring users to provide an AMI.
…-aws-gov Bug 2047258: Read GovCloud from RHCOS stream
Bug 2041750: [Alibaba] fix endpoint error in some regions
Bug 2041765: Adjust the startup order of httpd container
…-options Bug 2042036: remove options for existing resources which are currently not supported
…ation Bug 2025868: Check HyperVGenerations for instance type
Bug 2035720: [Alibaba] support internal publish strategy
Bug 2040143: [Alibaba] remove unsupport regions
Bug 2042770: [Alibaba] fix resource creation for existing network
Bug 2042370: [Alibaba] fix installer index panic
Bug 2043297: bump RHCOS 4.10 bootimage metadata
Bug 2045916: IBMCloud: Stop defaulting to dedicated storage profile
Bug 2043003: [Alibaba] fix destroy not exist security group
Bug 2046025: [Alibaba] fix destory exist private zone
Bug 2047255: [Alibaba] fix validation of resource group ID
…e-ostype Bug 2047455: Update custom image os type
[OCPCLOUD-1385] Ensure removal of placement-groups during cluster destroy on AWS
Remove Caleb Boylan from core installer reviewers
Author
|
I can't test this because there's an image import issue, but I don't want to get too far out of date so I'm going to go ahead and merge this. It passed CI and hits the image import issue so I'm banking on the fact that everything else is still fine. There weren't any major merge conflicts to resolve thankfully so not concerned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manual merge