Bug 2045927: Add proxy for ironic-agent.service #5569

zhouhao3 · 2022-01-24T08:08:29Z

Avoid the issue that ironic agent image cannot be downloaded due to network proxy.

See #5552 for details.

Signed-off-by: Zhou Hao [email protected]

openshift-ci · 2022-01-24T08:11:10Z

Hi @zhouhao3. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Avoid the issue that ironic agent image cannot be downloaded due to network proxy. Signed-off-by: Zhou Hao <[email protected]>

dtantsur · 2022-01-24T13:44:51Z

/ok-to-test

zhouhao3 · 2022-01-25T03:18:51Z

/retest

dtantsur · 2022-01-25T09:15:46Z

/lgtm

openshift-ci · 2022-01-26T01:06:12Z

@zhouhao3: This pull request references Bugzilla bug 2045927, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

Bug 2045927: Add proxy for ironic-agent.service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhjanders · 2022-01-26T01:17:11Z

/test e2e-aws-workers-rhel8

rhjanders · 2022-01-26T01:17:22Z

/test e2e-metal-ipi-ovn-dualstack

rhjanders · 2022-01-26T02:56:30Z

/test e2e-aws-workers-rhel8

hase1128 · 2022-01-26T04:15:58Z

/test e2e-aws-workers-rhel8

rhjanders · 2022-01-26T05:08:32Z

/test e2e-metal-ipi-ovn-dualstack

zhouhao3 · 2022-01-26T05:30:22Z

/retest

rhjanders · 2022-01-26T06:36:14Z

/test e2e-aws-workers-rhel8

ardaguclu · 2022-01-26T06:43:30Z

Failing 2 test are perm-failing.

/approve

openshift-ci · 2022-01-26T06:44:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~data/data/bootstrap/baremetal/OWNERS~~ [ardaguclu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rhjanders · 2022-01-26T07:33:39Z

/test e2e-aws-workers-rhel8

openshift-bot · 2022-01-26T07:52:55Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-26T15:37:46Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-26T16:01:46Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

zhouhao3 · 2022-01-26T16:48:03Z

/retest

openshift-bot · 2022-01-26T17:50:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-26T18:15:46Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

ardaguclu · 2022-01-26T18:19:56Z

e2e-alibaba looks broken. But metal-ipi-ovn-ipv6 should pass.

/override e2e-alibaba

openshift-ci · 2022-01-26T18:20:38Z

@ardaguclu: ardaguclu unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

Details

In response to this:

e2e-alibaba looks broken. But metal-ipi-ovn-ipv6 should pass.

/override e2e-alibaba

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-01-26T19:03:46Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-26T22:25:47Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-26T23:43:49Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-27T00:09:46Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-27T00:35:46Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-27T00:48:46Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-27T01:40:45Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-27T05:55:55Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

ardaguclu · 2022-01-27T06:10:37Z

@staebler this e2e-alibaba job was added very recently but it is permanently failing.

Would you mind to override it?, because it is in required list. Thanks.

openshift-bot · 2022-01-27T07:43:55Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-27T08:19:56Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-27T09:19:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-27T09:31:58Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-27T09:43:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

hardys · 2022-01-27T10:47:19Z

@staebler this e2e-alibaba job was added very recently but it is permanently failing.

Would you mind to override it?, because it is in required list. Thanks.

+1 I see several PRs with fixes for alibaba but this change is clearly only impacting baremetal platform, so IMO overriding would be reasonable (the bz associated with this PR has been identified as a blocker)

The e2e-metal-ipi-ovn-dualstack job has been broken recently and several fixes have been in progress, so I think we can ignore that failure (the other metal-ipi jobs passed)

Perhaps @staebler or @patrickdillon can take a look and confirm if they're happy to override so this can merge :)

patrickdillon · 2022-01-27T11:53:32Z

/override ci/prow/e2e-alibaba

This job was marked required by accident

openshift-ci · 2022-01-27T11:54:02Z

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-alibaba

Details

In response to this:

/override ci/prow/e2e-alibaba

This job was marked required by accident

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-01-27T11:54:03Z

@zhouhao3: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-workers-rhel8	`254dfcb`	link	false	`/test e2e-aws-workers-rhel8`
ci/prow/e2e-metal-ipi-ovn-dualstack	`254dfcb`	link	false	`/test e2e-metal-ipi-ovn-dualstack`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-01-27T11:54:55Z

@zhouhao3: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

openshift-metal3/dev-scripts#1341 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2045927 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 2045927: Add proxy for ironic-agent.service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zhouhao3 mentioned this pull request Jan 24, 2022

IPI fails on iRMC servers due to unable to download Ironic Agent image #5552

Closed

openshift-ci bot requested review from ardaguclu and hardys January 24, 2022 08:11

openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 24, 2022

zhouhao3 force-pushed the add-proxy branch from c3b4553 to 254dfcb Compare January 24, 2022 08:26

Add proxy for ironic-agent.service

254dfcb

Avoid the issue that ironic agent image cannot be downloaded due to network proxy. Signed-off-by: Zhou Hao <[email protected]>

openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 24, 2022

openshift-ci bot assigned dtantsur Jan 25, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2022

zhouhao3 changed the title ~~Add proxy for ironic-agent.service~~ Bug 2045927: Add proxy for ironic-agent.service Jan 26, 2022

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 26, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2022

openshift-ci bot mentioned this pull request Jan 26, 2022

Bug 2045927: Add proxy for image-customization-controller openshift/cluster-baremetal-operator#240

Merged

openshift-merge-robot merged commit f2cbbed into openshift:master Jan 27, 2022

hardys mentioned this pull request Feb 11, 2022

baremetal: remove redundant proxy setting #5598

Merged

zhouhao3 deleted the add-proxy branch November 30, 2022 05:30

Bug 2045927: Add proxy for ironic-agent.service #5569

Bug 2045927: Add proxy for ironic-agent.service #5569

Uh oh!

Conversation

zhouhao3 commented Jan 24, 2022

Uh oh!

openshift-ci bot commented Jan 24, 2022

Uh oh!

dtantsur commented Jan 24, 2022

Uh oh!

zhouhao3 commented Jan 25, 2022

Uh oh!

dtantsur commented Jan 25, 2022

Uh oh!

openshift-ci bot commented Jan 26, 2022

Uh oh!

rhjanders commented Jan 26, 2022

Uh oh!

rhjanders commented Jan 26, 2022

Uh oh!

rhjanders commented Jan 26, 2022

Uh oh!

hase1128 commented Jan 26, 2022

Uh oh!

rhjanders commented Jan 26, 2022

Uh oh!

zhouhao3 commented Jan 26, 2022

Uh oh!

rhjanders commented Jan 26, 2022

Uh oh!

ardaguclu commented Jan 26, 2022

Uh oh!

openshift-ci bot commented Jan 26, 2022

Uh oh!

rhjanders commented Jan 26, 2022

Uh oh!

openshift-bot commented Jan 26, 2022

Uh oh!

openshift-bot commented Jan 26, 2022

Uh oh!

openshift-bot commented Jan 26, 2022

Uh oh!

zhouhao3 commented Jan 26, 2022

Uh oh!

openshift-bot commented Jan 26, 2022

Uh oh!

openshift-bot commented Jan 26, 2022

Uh oh!

ardaguclu commented Jan 26, 2022

Uh oh!

openshift-ci bot commented Jan 26, 2022

Uh oh!

openshift-bot commented Jan 26, 2022

Uh oh!

openshift-bot commented Jan 26, 2022

Uh oh!

openshift-bot commented Jan 26, 2022

Uh oh!

openshift-bot commented Jan 27, 2022

Uh oh!

openshift-bot commented Jan 27, 2022

Uh oh!

openshift-bot commented Jan 27, 2022

Uh oh!

openshift-bot commented Jan 27, 2022

Uh oh!

openshift-bot commented Jan 27, 2022

Uh oh!

ardaguclu commented Jan 27, 2022

Uh oh!

openshift-bot commented Jan 27, 2022

Uh oh!

openshift-bot commented Jan 27, 2022

Uh oh!

openshift-bot commented Jan 27, 2022

Uh oh!

openshift-bot commented Jan 27, 2022

Uh oh!

openshift-bot commented Jan 27, 2022

Uh oh!