Skip to content

Conversation

@pierreprinetti
Copy link
Member

Fix the reference to an unbound variable; avoid incrementing the invalid
certificate counter in a subshell.

/cc mandre

Fix the reference to an unbound variable; avoid incrementing the invalid
certificate counter in a subshell.
@openshift-ci openshift-ci bot requested a review from mandre January 25, 2022 08:34
@pierreprinetti pierreprinetti changed the title openstack: Fix invalid-https-certificate detection Bug 2038166: openstack: Fix invalid-https-certificate detection Jan 25, 2022
@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Jan 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2022

@pierreprinetti: This pull request references Bugzilla bug 2038166, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

Bug 2038166: openstack: Fix invalid-https-certificate detection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 25, 2022
@pierreprinetti
Copy link
Member Author

/cc @maxwelldb

@pierreprinetti
Copy link
Member Author

/skip
docs PR

Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 25, 2022
@openshift-merge-robot openshift-merge-robot merged commit 6c2c8ae into openshift:master Jan 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2022

@pierreprinetti: All pull requests linked via external trackers have merged:

Bugzilla bug 2038166 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2038166: openstack: Fix invalid-https-certificate detection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2022

@pierreprinetti: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierreprinetti pierreprinetti deleted the openstack-fix-invalid-cert-script branch January 25, 2022 09:05
@maxwelldb
Copy link
Contributor

@pierreprinetti Noted. Incorporating into openshift/openshift-docs#40785.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants