Skip to content

Bug 2042370: [Alibaba] fix installer index panic #5575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 28, 2022
Merged

Bug 2042370: [Alibaba] fix installer index panic #5575

openshift-merge-robot merged 1 commit into from
Jan 28, 2022

Conversation

@bd233
Copy link
Contributor

@bd233 bd233 commented Jan 25, 2022

And add NAT gateway validation to check the region whether support NAT gateway

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2022

@bd233: This pull request references Bugzilla bug 2042370, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianli-wei

Details

In response to this:

Bug 2042370: [Alibaba] fix installer index panic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

patrickdillon
patrickdillon reviewed Jan 25, 2022
View reviewed changes
pkg/asset/cluster/tfvars.go Outdated
Comment on lines 744 to 746
Copy link
Contributor

@patrickdillon patrickdillon Jan 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed here as well as in the install config validation? Isn't it sufficient to check once?

Copy link
Contributor Author

@bd233 bd233 Jan 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After I added this check, I realized it would be more appropriate to add a validation, but I'm not sure if it's superfluous, so I kept it

Copy link
Contributor

@patrickdillon patrickdillon Jan 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah you can remove this entire check from here. The install config validation will cover it.

Copy link
Contributor Author

@bd233 bd233 Jan 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have removed

@bd233
Alibaba: fix installer index panic
9e2276f 
Add NAT gateway validation to check the region whether support NAT gateway

Signed-off-by: sunhui <[email protected]>
@patrickdillon
Copy link
Contributor

patrickdillon commented Jan 27, 2022

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2022
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 27, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 27, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 27, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2022

@bd233: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-upi 5c1d8e6b038c61b4b80f619bd8a9fdeadb0ba656 link false /test e2e-azure-upi
ci/prow/e2e-metal-ipi-ovn-ipv6 9e2276f link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-workers-rhel7 9e2276f link false /test e2e-aws-workers-rhel7
ci/prow/e2e-crc 9e2276f link false /test e2e-crc
ci/prow/okd-e2e-aws 9e2276f link false /test okd-e2e-aws
ci/prow/e2e-aws-workers-rhel8 9e2276f link false /test e2e-aws-workers-rhel8
ci/prow/e2e-alibaba 9e2276f link true /test e2e-alibaba
ci/prow/e2e-ibmcloud 9e2276f link false /test e2e-ibmcloud
ci/prow/okd-e2e-aws-upgrade 9e2276f link false /test okd-e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 28, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@patrickdillon
Copy link
Contributor

patrickdillon commented Jan 28, 2022

/skip

@patrickdillon
Copy link
Contributor

patrickdillon commented Jan 28, 2022

/override ci/prow/e2e-aws ci/prow/e2e-aws-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2022

@patrickdillon: /override requires a failed status context or a job name to operate on.
The following unknown contexts were given:

  • ci/prow/e2e-aws ci/prow/e2e-aws-upgrade

Only the following contexts were expected:

  • ci/prow/e2e-alibaba
  • ci/prow/e2e-aws
  • ci/prow/e2e-aws-fips
  • ci/prow/e2e-aws-single-node
  • ci/prow/e2e-aws-upgrade
  • ci/prow/e2e-aws-workers-rhel7
  • ci/prow/e2e-aws-workers-rhel8
  • ci/prow/e2e-crc
  • ci/prow/e2e-ibmcloud
  • ci/prow/e2e-libvirt
  • ci/prow/e2e-metal-ipi-ovn-ipv6
  • ci/prow/e2e-metal-single-node-live-iso
  • ci/prow/e2e-openstack
  • ci/prow/e2e-openstack-kuryr
  • ci/prow/e2e-ovirt
  • ci/prow/gofmt
  • ci/prow/golint
  • ci/prow/govet
  • ci/prow/images
  • ci/prow/okd-e2e-aws
  • ci/prow/okd-e2e-aws-upgrade
  • ci/prow/okd-images
  • ci/prow/okd-unit
  • ci/prow/okd-verify-codegen
  • ci/prow/openstack-manifests
  • ci/prow/shellcheck
  • ci/prow/tf-fmt
  • ci/prow/tf-lint
  • ci/prow/unit
  • ci/prow/verify-codegen
  • ci/prow/verify-vendor
  • ci/prow/yaml-lint
  • pull-ci-openshift-installer-fcos-e2e-aws
  • pull-ci-openshift-installer-fcos-e2e-openstack
  • pull-ci-openshift-installer-fcos-gofmt
  • pull-ci-openshift-installer-fcos-golint
  • pull-ci-openshift-installer-fcos-govet
  • pull-ci-openshift-installer-fcos-images
  • pull-ci-openshift-installer-fcos-unit
  • pull-ci-openshift-installer-fcos-verify-codegen
  • pull-ci-openshift-installer-fcos-verify-vendor
  • pull-ci-openshift-installer-master-e2e-alibaba
  • pull-ci-openshift-installer-master-e2e-aws-fips
  • pull-ci-openshift-installer-master-e2e-aws-single-node
  • pull-ci-openshift-installer-master-e2e-aws-upgrade
  • pull-ci-openshift-installer-master-e2e-aws-workers-rhel7
  • pull-ci-openshift-installer-master-e2e-aws-workers-rhel8
  • pull-ci-openshift-installer-master-e2e-crc
  • pull-ci-openshift-installer-master-e2e-ibmcloud
  • pull-ci-openshift-installer-master-e2e-libvirt
  • pull-ci-openshift-installer-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-installer-master-e2e-metal-single-node-live-iso
  • pull-ci-openshift-installer-master-e2e-openstack-kuryr
  • pull-ci-openshift-installer-master-e2e-ovirt
  • pull-ci-openshift-installer-master-okd-e2e-aws
  • pull-ci-openshift-installer-master-okd-e2e-aws-upgrade
  • pull-ci-openshift-installer-master-okd-images
  • pull-ci-openshift-installer-master-okd-unit
  • pull-ci-openshift-installer-master-okd-verify-codegen
  • pull-ci-openshift-installer-master-openstack-manifests
  • pull-ci-openshift-installer-master-shellcheck
  • pull-ci-openshift-installer-master-tf-fmt
  • pull-ci-openshift-installer-master-tf-lint
  • pull-ci-openshift-installer-master-yaml-lint
  • tide
Details

In response to this:

/override ci/prow/e2e-aws ci/prow/e2e-aws-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 70e8aed into openshift:master Jan 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2022

@bd233: All pull requests linked via external trackers have merged:

Bugzilla bug 2042370 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2042370: [Alibaba] fix installer index panic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon patrickdillon left review comments

@jianli-wei jianli-wei Awaiting requested review from jianli-wei

@kirankt kirankt Awaiting requested review from kirankt

@rna-afk rna-afk Awaiting requested review from rna-afk

Assignees

@patrickdillon patrickdillon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bd233 @patrickdillon @openshift-bot @openshift-merge-robot