Skip to content

Bug 2037209: vendor: update openshift/api to latest in preparation for alibaba machine provider changes #5563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 3 commits into from
Jan 24, 2022
Merged

Bug 2037209: vendor: update openshift/api to latest in preparation for alibaba machine provider changes #5563

openshift-merge-robot merged 3 commits into from
Jan 24, 2022

Conversation

@staebler
Copy link
Contributor

@staebler staebler commented Jan 21, 2022

  • Update openshift/api to 0a830aea20c2.
  • Update kube modules to v0.23.0.
  • Update controller-runtime to v0.11.0.
  • Remove unused terraform-provider-kubernetes.
  • Updated the hack/verify-codegen.sh script to use an image containing go 1.17, rather than go 1.16.

@staebler
remove unused kube terraform provider
d111ca9
@staebler
vendor: update openshift/api to include some alibaba infra changes
af4738a 
* Update openshift/api to 6e0b1eb97188.
* Update kube modules to v0.23.0.
* Update controller-runtime to v0.11.0.
* Remove unused terraform-provider-kubernetes.
@staebler
hack: use go 1.17 for verifying codegen
ce31697 
The hack/verify-codegen.sh script was using an image that included
go 1.16. However, the updated k8s.io/json module calls the
`(reflect.StructField) IsExported` function, which is new in go 1.17.
Consequently, the script needs to be updated to use an image that
include go 1.17 rather than 1.16.
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2022

@staebler: This pull request references Bugzilla bug 2037209, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianli-wei

Details

In response to this:

Bug 2037209: vendor: update openshift/api to latest in preparation for alibaba machine provider changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jianli-wei January 21, 2022 21:57
@staebler
Copy link
Contributor Author

staebler commented Jan 21, 2022

This is to prepare for the bump of openshift/api in #5562.

@openshift-ci openshift-ci bot requested review from kirankt and rna-afk January 21, 2022 22:00
@elmiko elmiko mentioned this pull request Jan 21, 2022
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 22, 2022 •
edited
Loading

@staebler: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-fips ce31697 link false /test e2e-aws-fips
ci/prow/e2e-aws-workers-rhel7 ce31697 link false /test e2e-aws-workers-rhel7
ci/prow/e2e-ibmcloud ce31697 link false /test e2e-ibmcloud
ci/prow/okd-e2e-aws-upgrade ce31697 link false /test okd-e2e-aws-upgrade
ci/prow/e2e-aws-workers-rhel8 ce31697 link false /test e2e-aws-workers-rhel8
ci/prow/e2e-aws-single-node ce31697 link false /test e2e-aws-single-node
ci/prow/e2e-azure-upi ce31697 link false /test e2e-azure-upi
ci/prow/e2e-metal-single-node-live-iso ce31697 link false /test e2e-metal-single-node-live-iso
ci/prow/e2e-crc ce31697 link false /test e2e-crc

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kwoodson
Copy link

kwoodson commented Jan 24, 2022

@staebler @patrickdillon @elmiko

INFO Install complete!                            
INFO To access the cluster as the system:admin user when using 'oc', run 'export KUBECONFIG=/home/kwoodson/tmp/alibaba/cluster/auth/kubeconfig' 
INFO Access the OpenShift web-console here: https://console-openshift-console.apps.test.alicloud-dev.devcluster.openshift.com 
INFO Login to the console with user: "kubeadmin", and password: "xxxxxxxxxx" 
DEBUG Time elapsed per stage:                      
DEBUG            cluster: 2m40s                    
DEBUG          bootstrap: 1m10s                    
DEBUG Bootstrap Complete: 22m17s                   
DEBUG                API: 6m13s                    
DEBUG  Bootstrap Destroy: 40s                      
DEBUG  Cluster Operators: 7m28s                    
INFO Time elapsed: 34m21s

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2022
@patrickdillon
Copy link
Contributor

patrickdillon commented Jan 24, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2022
@elmiko
Copy link
Contributor

elmiko commented Jan 24, 2022

/test e2e-aws-upgrade

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6bd4f3e into openshift:master Jan 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 24, 2022

@staebler: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2037209 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 2037209: vendor: update openshift/api to latest in preparation for alibaba machine provider changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot mentioned this pull request Jan 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jianli-wei jianli-wei Awaiting requested review from jianli-wei

@kirankt kirankt Awaiting requested review from kirankt

@rna-afk rna-afk Awaiting requested review from rna-afk

Assignees

@kwoodson kwoodson

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@staebler @kwoodson @patrickdillon @elmiko @openshift-bot @openshift-merge-robot