Bug 2047258: Read GovCloud from RHCOS stream

[patrickdillon]

AMIs for GovCloud regions have been added to the RHCOS stream. Remove
validation requiring users to provide an AMI.

[openshift-ci]

@patrickdillon: This pull request references Bugzilla bug 2047258, which is invalid:

• expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2047258: Read GovCloud from RHCOS stream

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[patrickdillon]

/bugzilla refresh

[openshift-ci]

@patrickdillon: This pull request references Bugzilla bug 2047258, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.10.0) matches configured target release for branch (4.10.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jstuever]

/retest

[jstuever]

/assign

[jstuever]

Looks like some unit tests need modification to no longer use these regions....
https://github.com/openshift/installer/blob/4208655768d0f08d5913d786f7bab0b08d38ed70/pkg/types/aws/validation/machinepool_test.go#L83-L104

[patrickdillon]

Looks like some unit tests need modification to no longer use these regions....

https://github.com/openshift/installer/blob/4208655768d0f08d5913d786f7bab0b08d38ed70/pkg/types/aws/validation/machinepool_test.go#L83-L104

Thanks for catching that. Let's see if this newest push fixes it.

[patrickdillon]

ok it's fixed!

[jstuever]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/types/aws/OWNERS [jstuever]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-workers-rhel7	d1c6a17	link	false	/test e2e-aws-workers-rhel7
ci/prow/e2e-aws-single-node	d1c6a17	link	false	/test e2e-aws-single-node
ci/prow/e2e-aws-workers-rhel8	d1c6a17	link	false	/test e2e-aws-workers-rhel8
ci/prow/okd-e2e-aws-upgrade	d1c6a17	link	false	/test okd-e2e-aws-upgrade
ci/prow/okd-e2e-aws	d1c6a17	link	false	/test okd-e2e-aws
ci/prow/e2e-aws-fips	d1c6a17	link	false	/test e2e-aws-fips

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@patrickdillon: All pull requests linked via external trackers have merged:

• openshift/installer#5585

Bugzilla bug 2047258 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2047258: Read GovCloud from RHCOS stream

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.