Bug 2037209: update alibaba for provider spec api changes #5562
Conversation
openshift-ci
bot
added
the
bugzilla/severity-high
|
@elmiko: This pull request references Bugzilla bug 2037209, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
this change will require openshift/api#1096 to merge first, it will not build until we can vendor those changes here. |
openshift-ci
bot
added
the
do-not-merge/hold
|
this will also need the actuator updated to work properly, see openshift/cluster-api-provider-alibaba#26 |
|
i have added a second commit to vendor from my branch of the api, this is only for testing and should be replaced before we merge. |
staebler
left a comment
staebler
left a comment
There was a problem hiding this comment.
/approve
These changes look good, but I need to do some locally testing for validation.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
elmiko
force-pushed
the
update-alibaba-api
branch
from
76f5532 to
5b2f937
Compare
|
this will need an update to the vendor to match k8s 1.23, i am coordinating with @staebler to get that change in a separate PR and then we will rebase this PR on top of it. |
elmiko
force-pushed
the
update-alibaba-api
branch
from
5b2f937 to
6fcda2e
Compare
|
i have rebuilt this on top of #5563 |
elmiko
force-pushed
the
update-alibaba-api
branch
from
6fcda2e to
92f201e
Compare
|
Changes LGTM once we have the API change merged |
elmiko
force-pushed
the
update-alibaba-api
branch
2 times, most recently
from
4e8f54c to
6dd72fb
Compare
|
i have revendored for the API changes, we will still need to manually test this one more time and also it will need to wait for #5563 |
elmiko
force-pushed
the
update-alibaba-api
branch
from
6dd72fb to
394b74e
Compare
|
update
|
elmiko
force-pushed
the
update-alibaba-api
branch
from
394b74e to
f01e352
Compare
This change updates the alibaba provider spec usage related to the vswitch, security groups, and resource group. The API for the provider spec is changing to use a discriminated union to capture the various methods for finding resources (by id, name, or tags). It also updates several machine api references to note the bifurcated nature of the api version between v1beta1 and v1.
This change is to update the vendor references to support the Alibaba resrouce reference updates to the API.
elmiko
force-pushed
the
update-alibaba-api
branch
from
f01e352 to
2c8806f
Compare
|
update
|
|
i am removing the hold here since #5563 has merged |
openshift-ci
bot
removed
the
do-not-merge/hold
|
I was able to successfully deploy nodes: New fields used: /lgtm |
|
removing the hold as we have all pieces in place and good manual testing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@elmiko: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@elmiko: All pull requests linked via external trackers have merged:
Bugzilla bug 2037209 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
This change updates the alibaba provider spec usage related to the
vswitch, security groups, and resource group. The API for the provider
spec is changing to use a discriminated union to capture the various
methods for finding resources (by id, name, or tags).
It also updates several machine api references to note the bifurcated
nature of the api version between v1beta1 and v1.