Bug 2042036: remove options for existing resources which are currently not supported #5568

jeffnowicki · 2022-01-24T00:33:38Z

The only supported 'existing resource' for 4.10 is a resource group. The additional existing resource options for vpc and subnets will be a future release consideration. Those options will be removed as options at this time. How soon those options can be supported will be a prioritization activity based on other considerations and available resources.

openshift-ci · 2022-01-24T03:23:16Z

@jeffnowicki: This pull request references Bugzilla bug 2042036, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2042036: remove options for existing resources which are currently not supported

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pamoedom · 2022-01-24T09:33:19Z

/bugzilla refresh

openshift-ci · 2022-01-24T09:33:25Z

@pamoedom: This pull request references Bugzilla bug 2042036, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @pamoedom

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kirankt

/lgtm

hasueki · 2022-01-24T15:46:34Z

@jeffnowicki IIRC, the contents for data/data/install.openshift.io_installconfigs.yaml are auto-gen'd. I think we should remove the definitions from https://github.com/openshift/installer/blob/master/pkg/types/ibmcloud/platform.go#L4, and then generate the above file.

jeffnowicki · 2022-01-24T15:50:55Z

Thanks Hide... I'll correct the fix.

This reverts commit 2684f8d.

jeffnowicki · 2022-01-24T16:29:58Z

I still need to gen and commit install.openshift.io_installconfigs.yaml

jeffnowicki · 2022-01-24T18:58:11Z

/retest-required

kirankt · 2022-01-24T19:16:49Z

@jeffnowicki. These removed options are being checked during validation. Please remove references there as well. Thanks.
https://github.com/openshift/installer/blob/master/pkg/types/ibmcloud/validation/platform.go#L56-L64

jeffnowicki · 2022-01-24T21:15:49Z

@kirankt Thank you for the review/comments. I updated validation code per your comment.

This reverts commit 20f8626.

pamoedom · 2022-01-27T10:23:25Z

Hi @jeffnowicki, with your latest changes I was able to locally compile the installer and the tests are successful, the options are no longer present nor accepted, thanks:

$ ./openshift-install-local version
./openshift-install-local unreleased-master-5524-g55a9f62e2693962bd4340917efded7407570d95a
built from commit 55a9f62e2693962bd4340917efded7407570d95a
release image registry.ci.openshift.org/origin/release:4.10
release architecture amd64

$ ./openshift-install-local explain installconfig.platform.ibmcloud
KIND:     InstallConfig
VERSION:  v1

RESOURCE: <object>
  IBMCloud is the configuration used when installing on IBM Cloud.

FIELDS:
    defaultMachinePlatform <object>
      DefaultMachinePlatform is the default configuration used when installing on IBM Cloud for machine pools which do not define their own platform configuration.

    region <string> -required-
      Region specifies the IBM Cloud region where the cluster will be created.

    resourceGroupName <string>
      ResourceGroupName is the name of an already existing resource group where the cluster should be installed. This resource group should only be used for this specific cluster and the cluster components will assume ownership of all resources in the resource group. Destroying the cluster using installer will delete this resource group. 
 This resource group must be empty with no other resources when trying to use it for creating a cluster. If empty, a new resource group will be created for the cluster.

$ ./openshift-install-local create manifests --dir test52/
FATAL failed to fetch Master Machines: failed to load asset "Install Config": failed to unmarshal install-config.yaml: failed to parse first occurence of unknown field: error unmarshaling JSON: while decoding JSON: json: unknown field "subnets"

$ ./openshift-install-local create manifests --dir test52/
FATAL failed to fetch Master Machines: failed to load asset "Install Config": failed to unmarshal install-config.yaml: failed to parse first occurence of unknown field: error unmarshaling JSON: while decoding JSON: json: unknown field "vpc"

$ ./openshift-install-local create manifests --dir test52/
FATAL failed to fetch Master Machines: failed to load asset "Install Config": failed to unmarshal install-config.yaml: failed to parse first occurence of unknown field: error unmarshaling JSON: while decoding JSON: json: unknown field "vpcResourceGroupName"

Regards.

jeffnowicki · 2022-01-27T17:56:37Z

@kirankt would you review/add labels? Thank you!

jstuever · 2022-01-27T18:04:34Z

/assign

jstuever · 2022-01-27T18:36:27Z

/approve
I'll leave the lgtm for kirankt

kirankt

/lgtm

openshift-ci · 2022-01-27T19:15:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever, kirankt, pamoedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jstuever]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2022-01-27T19:35:59Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-27T21:58:58Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

jstuever · 2022-01-27T22:03:47Z

/retest

openshift-bot · 2022-01-27T22:24:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-28T04:38:19Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-28T05:03:56Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-28T06:28:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-28T07:28:55Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-28T07:52:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-28T08:28:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-28T08:40:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-28T10:05:01Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-28T10:52:58Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-28T12:17:00Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-01-28T13:25:39Z

@jeffnowicki: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-single-node	`55a9f62`	link	false	`/test e2e-aws-single-node`
ci/prow/e2e-aws-workers-rhel7	`55a9f62`	link	false	`/test e2e-aws-workers-rhel7`
ci/prow/e2e-ibmcloud	`55a9f62`	link	false	`/test e2e-ibmcloud`
ci/prow/okd-e2e-aws	`55a9f62`	link	false	`/test okd-e2e-aws`
ci/prow/e2e-crc	`55a9f62`	link	false	`/test e2e-crc`
ci/prow/e2e-aws-workers-rhel8	`55a9f62`	link	false	`/test e2e-aws-workers-rhel8`
ci/prow/e2e-alibaba	`55a9f62`	link	false	`/test e2e-alibaba`
ci/prow/e2e-azure-upi	`55a9f62`	link	false	`/test e2e-azure-upi`
ci/prow/okd-e2e-aws-upgrade	`55a9f62`	link	false	`/test okd-e2e-aws-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2022-01-28T13:40:56Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-01-28T13:56:19Z

@jeffnowicki: All pull requests linked via external trackers have merged:

openshift/installer#5568

Bugzilla bug 2042036 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2042036: remove options for existing resources which are currently not supported

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

remove unsupported options

2684f8d

openshift-ci bot requested review from kirankt and rna-afk January 24, 2022 00:34

jeffnowicki changed the title ~~Bug 2042036 : remove options for existing resources which are currently not supported~~ Bug 2042036: remove options for existing resources which are currently not supported Jan 24, 2022

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 24, 2022

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 24, 2022

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 24, 2022

openshift-ci bot requested a review from pamoedom January 24, 2022 09:33

pamoedom approved these changes Jan 24, 2022

View reviewed changes

kirankt reviewed Jan 24, 2022

View reviewed changes

openshift-ci bot assigned kirankt Jan 24, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2022

Revert "remove unsupported options"

fd20502

This reverts commit 2684f8d.

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2022

remove unsupported options for existing resources

969a775

jeffnowicki requested review from kirankt and pamoedom January 24, 2022 16:25

gen'd install configs yaml

35fadfc

remove validation related to unsupported options

20f8626

update validation for unsupported options

e5d628d

jeffnowicki added 2 commits January 26, 2022 20:24

Revert "remove validation related to unsupported options"

e82b27e

This reverts commit 20f8626.

remove validation for unsupported options

55a9f62

pamoedom approved these changes Jan 27, 2022

View reviewed changes

openshift-ci bot assigned jstuever Jan 27, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2022

kirankt approved these changes Jan 27, 2022

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2022

openshift-merge-robot merged commit 7062f2b into openshift:master Jan 28, 2022

Bug 2042036: remove options for existing resources which are currently not supported #5568

Bug 2042036: remove options for existing resources which are currently not supported #5568

Uh oh!

Conversation

jeffnowicki commented Jan 24, 2022

Uh oh!

openshift-ci bot commented Jan 24, 2022

Uh oh!

pamoedom commented Jan 24, 2022

Uh oh!

openshift-ci bot commented Jan 24, 2022

Uh oh!

kirankt left a comment

Choose a reason for hiding this comment

Uh oh!

hasueki commented Jan 24, 2022

Uh oh!

jeffnowicki commented Jan 24, 2022

Uh oh!

jeffnowicki commented Jan 24, 2022

Uh oh!

jeffnowicki commented Jan 24, 2022

Uh oh!

kirankt commented Jan 24, 2022

Uh oh!

jeffnowicki commented Jan 24, 2022

Uh oh!

pamoedom commented Jan 27, 2022

Uh oh!

jeffnowicki commented Jan 27, 2022

Uh oh!

jstuever commented Jan 27, 2022

Uh oh!

jstuever commented Jan 27, 2022

Uh oh!

kirankt left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jan 27, 2022

Uh oh!

openshift-bot commented Jan 27, 2022

Uh oh!

openshift-bot commented Jan 27, 2022

Uh oh!

jstuever commented Jan 27, 2022

Uh oh!

openshift-bot commented Jan 27, 2022

Uh oh!

openshift-bot commented Jan 28, 2022

Uh oh!

openshift-bot commented Jan 28, 2022

Uh oh!

openshift-bot commented Jan 28, 2022

Uh oh!

openshift-bot commented Jan 28, 2022

Uh oh!

openshift-bot commented Jan 28, 2022

Uh oh!

openshift-bot commented Jan 28, 2022

Uh oh!

openshift-bot commented Jan 28, 2022

Uh oh!

openshift-bot commented Jan 28, 2022

Uh oh!

openshift-bot commented Jan 28, 2022

Uh oh!

openshift-bot commented Jan 28, 2022

Uh oh!

openshift-ci bot commented Jan 28, 2022

Uh oh!

openshift-bot commented Jan 28, 2022

Uh oh!

openshift-ci bot commented Jan 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development