-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge to latest version & fix issues in code review #1
base: windows-impl
Are you sure you want to change the base?
Commits on Feb 11, 2022
-
Revert "[flutter_local_notifications ] Notification actions for iOS, …
…macOS, Android (MaikuB#880)" (MaikuB#1477) This reverts commit 8e1ad8e.
Configuration menu - View commit details
-
Copy full SHA for 870b8a4 - Browse repository at this point
Copy the full SHA 870b8a4View commit details -
[flutter_local_notifications] use apply() to save changes to shared p…
…references (MaikuB#1478) * use apply to save to shared preferences * fix grammar and formatting issues in API docs for colorized property * bump plugin to 9.3.0 and update changelog
Configuration menu - View commit details
-
Copy full SHA for 0a02eaa - Browse repository at this point
Copy the full SHA 0a02eaaView commit details -
[flutter_local_notifications] remove dart:ffi import (MaikuB#1480)
* remove dart:ffi import * fix changelog entry for dart:ffi fix
Configuration menu - View commit details
-
Copy full SHA for 1feacf4 - Browse repository at this point
Copy the full SHA 1feacf4View commit details
Commits on Feb 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3561d36 - Browse repository at this point
Copy the full SHA 3561d36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e3fe49 - Browse repository at this point
Copy the full SHA 3e3fe49View commit details
Commits on Feb 21, 2022
-
Updated all dependencies in [flutter_local_notifications_linux] to th…
…e … (MaikuB#1492) * Updated all dependencies in flutter_local_notifications_linux to the last version * Reverted back to path dependency version 1.8.0 as it is incompatible with flutter_test * bump linux plugin version Co-authored-by: Michael Bui <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c7428f3 - Browse repository at this point
Copy the full SHA c7428f3View commit details
Commits on Feb 28, 2022
-
[flutter_local_notifications] fix crash on calling requestPermissions…
… with default values (MaikuB#1510) * fix crash on calling requestPermissions with default values * revert changes to example app
Configuration menu - View commit details
-
Copy full SHA for a5c4814 - Browse repository at this point
Copy the full SHA a5c4814View commit details
Commits on Mar 5, 2022
-
Add ActiveNotification.tag (MaikuB#1513)
Allows users to fetch an active notification tag. Closes: MaikuB#1512
Configuration menu - View commit details
-
Copy full SHA for f371695 - Browse repository at this point
Copy the full SHA f371695View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c0b2db - Browse repository at this point
Copy the full SHA 2c0b2dbView commit details
Commits on Apr 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8373b64 - Browse repository at this point
Copy the full SHA 8373b64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2558b2e - Browse repository at this point
Copy the full SHA 2558b2eView commit details
Commits on Apr 23, 2022
-
[flutter_local_notifications] Throw ArgumentError when trying to init…
…ialize LocalNotification without per Platform settings (MaikuB#1559) * change: throw ArgumentError when trying to initialize LocalNotifications without per Platform settings add: tests * fix: typo * change: apply suggested changes add: new line in the readme change: the ArgumentError texts change: fix: capitalization of macOs change: apply text changes in the integration test change: make test case text more obvious * change: casing of macOS * formatting api docs per effective dart docs and bump plugin Co-authored-by: Michael Bui <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3932f20 - Browse repository at this point
Copy the full SHA 3932f20View commit details -
[flutter_local_notifications] DST, function typo, header and newline …
…consistency in readme (MaikuB#1571) * DST and function typo My understanding is that the best way of referring to DST is not "daylight savingS" but "daylight saving", and I put in "time" for completeness for a readme. https://en.wikipedia.org/wiki/Daylight_saving_time * Linearly changing header levels; consistent newlines Some headers were level 4 and 5 after a level 2 header, so I bumped them up. I removed extra newlines and added missing ones since most of the doc uses the style of 2 newlines after a header.
Configuration menu - View commit details
-
Copy full SHA for 8d2b0c9 - Browse repository at this point
Copy the full SHA 8d2b0c9View commit details -
update api docs referencing daylight savings and include changelog en…
…try for docs updates
Configuration menu - View commit details
-
Copy full SHA for b187373 - Browse repository at this point
Copy the full SHA b187373View commit details
Commits on May 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 659508f - Browse repository at this point
Copy the full SHA 659508fView commit details
Commits on May 3, 2022
-
Add getActiveNotificationMessagingStyle (MaikuB#1541)
This allows fetching an active notification's MessagingStyleInformation. A typical use-case is appending a new Message to a MessagingStyle when receiving a push message.
Configuration menu - View commit details
-
Copy full SHA for e0fa35a - Browse repository at this point
Copy the full SHA e0fa35aView commit details -
github-actions committed
May 3, 2022 Configuration menu - View commit details
-
Copy full SHA for 9987a57 - Browse repository at this point
Copy the full SHA 9987a57View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9336f4 - Browse repository at this point
Copy the full SHA a9336f4View commit details
Commits on May 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for d84739d - Browse repository at this point
Copy the full SHA d84739dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 28767ed - Browse repository at this point
Copy the full SHA 28767edView commit details
Commits on May 6, 2022
-
[flutter_local_notifications] fix crash when push notification happen…
…s on macOS (MaikuB#1590) * check if plugin should process notification * Swift Format * bump to 9.5.2 Co-authored-by: runner <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a19c9cd - Browse repository at this point
Copy the full SHA a19c9cdView commit details
Commits on May 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 621e6ff - Browse repository at this point
Copy the full SHA 621e6ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 330910b - Browse repository at this point
Copy the full SHA 330910bView commit details -
update proguard rules in example app and readme on proguard rules and…
… onSelectNotification callback (MaikuB#1595)
Configuration menu - View commit details
-
Copy full SHA for e0387e1 - Browse repository at this point
Copy the full SHA e0387e1View commit details
Commits on Jun 4, 2022
-
[flutter_local_notifications_linux] Add support for the file path ic…
…ons (MaikuB#1602) * Fix warnings on Flutter 3.0.0, upgrade dependencies * [Linux] Add support for the file path icons * [Linux] Add the file path icon to the example
Configuration menu - View commit details
-
Copy full SHA for 5e279b0 - Browse repository at this point
Copy the full SHA 5e279b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for c97e797 - Browse repository at this point
Copy the full SHA c97e797View commit details -
Configuration menu - View commit details
-
Copy full SHA for f07ebab - Browse repository at this point
Copy the full SHA f07ebabView commit details -
Configuration menu - View commit details
-
Copy full SHA for cd4d5a1 - Browse repository at this point
Copy the full SHA cd4d5a1View commit details
Commits on Jun 16, 2022
-
fix zonedSchedule error on macOS when matching using dayOfMonthAndTim…
…e or dateAndTime (MaikuB#1628)
Configuration menu - View commit details
-
Copy full SHA for 987ec0c - Browse repository at this point
Copy the full SHA 987ec0cView commit details
Commits on Jul 6, 2022
-
[flutter_local_notifications] Documentation: updated dead link (Maiku…
…B#1641) * updated "Icon design status bar" link prev link redirects to material design > 404 * added archived label
Configuration menu - View commit details
-
Copy full SHA for 0b20a45 - Browse repository at this point
Copy the full SHA 0b20a45View commit details
Commits on Jul 10, 2022
-
[flutter_local_notifications] show number for Android (MaikuB#1637)
Configuration menu - View commit details
-
Copy full SHA for 09e7df6 - Browse repository at this point
Copy the full SHA 09e7df6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31d47e0 - Browse repository at this point
Copy the full SHA 31d47e0View commit details
Commits on Jul 31, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c0192bb - Browse repository at this point
Copy the full SHA c0192bbView commit details
Commits on Aug 14, 2022
-
[flutter_local_notifications] updates how launch intent is read for g…
…etNotificationAppLaunchDetails (MaikuB#1672) * updates how launch intent is read for getNotificationAppLaunchDetails * Google Java Format Co-authored-by: github-actions <>
Configuration menu - View commit details
-
Copy full SHA for 66687fd - Browse repository at this point
Copy the full SHA 66687fdView commit details
Commits on Aug 17, 2022
-
[flutter_local_notifications] Add support for Android Tiramisu' `POST…
…_NOTIFICATIONS` permission (MaikuB#1658) * implement Android side of `requestPermission` * implement Flutter side of `requestPermission` and `isPermissionGranted` * implement Android side of `isPermissionGranted` * clean up the big switch in `onMethodCall` * bump Android SDK version in example app's `build.gradle` * add `android.permission.POST_NOTIFICATIONS` to Manifest * remove `sourceCompatibility` and `targetCompatibility` which were added by mistake * remove `isPermissionGranted` – it is the same as `areNotificationsEnabled` * remove `isPermissionGranted` in Java code * return `bool` from Android's `requestPermission` debugging in progress * fighting * HAHAHAHAAHAH FIXED * cleanup * show whether notifications are enabled * add flag which prevents crashes when permissions are requested twice * remove code calling requestPermissions() twice * fail a `MethodCall` when another permission request is already in progress * fix grammar in error message when permission request is already in progress Co-authored-by: Michael Bui <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f13b9b9 - Browse repository at this point
Copy the full SHA f13b9b9View commit details -
github-actions committed
Aug 17, 2022 Configuration menu - View commit details
-
Copy full SHA for d3553c5 - Browse repository at this point
Copy the full SHA d3553c5View commit details -
[flutter_local_notifications] add docs on request permission to show …
…notification on Android (MaikuB#1675) * add docs on request permission to show notification on Android * Google Java Format Co-authored-by: github-actions <>
Configuration menu - View commit details
-
Copy full SHA for 52af054 - Browse repository at this point
Copy the full SHA 52af054View commit details -
[flutter_local_notifications] updated docs to mention compileSdkVersi…
…on changes needed for 9.8.0 (MaikuB#1677) * updated docs to mention compileSdkVersion changes needed for 9.8.0 * fix changelog and mention plugin's compileSdkVersion is now 33
Configuration menu - View commit details
-
Copy full SHA for 84766b6 - Browse repository at this point
Copy the full SHA 84766b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d795f0 - Browse repository at this point
Copy the full SHA 7d795f0View commit details
Commits on Aug 29, 2022
-
[flutter_local_notifications] Add audioAttributesUsage to Notificatio…
…nDetails (MaikuB#1649) * Add audioAttributesUsage to NotificationDetails Allows users to change AudioAttributes (https://developer.android.com/reference/android/media/AudioAttributes) to the notification sound Closes: MaikuB#1519 * Adding null check when reading audioAttributesUsage in FlutterLocalNotificationsPlugin * Adding missing enum 'notificationRingtone' in AudioAttributesUsage's property, 'values'
Configuration menu - View commit details
-
Copy full SHA for 801b6ca - Browse repository at this point
Copy the full SHA 801b6caView commit details -
github-actions committed
Aug 29, 2022 Configuration menu - View commit details
-
Copy full SHA for bc5d6ea - Browse repository at this point
Copy the full SHA bc5d6eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for b707190 - Browse repository at this point
Copy the full SHA b707190View commit details
Commits on Sep 3, 2022
-
Check permissionRequestInProgress in onRequestPermissionsResult (Maik…
…uB#1686) Other flutter plugins permissions requests can end up triggering onRequestPermissionsResult, so only handle callbacks when we're expecting one to be outstanding. This fixes a `java.lang.IllegalStateException: Reply already submitted` crash.
Configuration menu - View commit details
-
Copy full SHA for c901b4f - Browse repository at this point
Copy the full SHA c901b4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ae832a3 - Browse repository at this point
Copy the full SHA ae832a3View commit details
Commits on Sep 11, 2022
-
[flutter_local_notifications] Update pub.dev links (MaikuB#1693)
* Update pub.dev links Co-authored-by: Daniel Flores Medina <[email protected]> * Update pubspec.yaml Co-authored-by: Daniel Flores Medina <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0fff663 - Browse repository at this point
Copy the full SHA 0fff663View commit details
Commits on Sep 17, 2022
-
Implements notifications actions, reworked callbacks getActiveNotific…
…ations on iOS and macOS, iOS and macOS refactoring and renamed Android error codes (MaikuB#1406) * Added support for active notifications on iOS (MaikuB#1391) * Added support for active notifications on iOS * bump platform interface to 6.0.0-dev.1 for prerelease Co-authored-by: Michael Bui <[email protected]> * Google Java Format * fix version of platform interface * Swift Format * update error codes for unsupported os version and existing error codes to lower case * Swift Format * update groupKey changelog details * Clang Format * bump platform interface dependency used by linux plugin * bump linux plugin for prerelease * use dependency overrides for example app * update text in example app for getActiveNotifications example around unsupported iOS version * bump main plugin for prerelease * bump cross-platform facing plugin's dependency on linux plugin * call apply method for shared preferences editor instead of committing in background via a thread * fix linux plugin pubspec * update example to use device_info_plus instead of device_info * Clang Format * address linter issues * refactored iOS and macOS classes * update readme based on iOS/macOS refactoring and tweaks to docs around actions * fix section around handling notifications when app is in the foreground for iOS * updates for pre-release * add changelog entry on breaking change for refactoring iOS and macOS classes * bump platform interface dependency * rename callback for selecting notification action * rename method invoked from macos when action is selected * bump linux dependency * [flutter_local_notifications_linux] Add actions support in Linux (MaikuB#1442) * Add actions support in Linux * Update README * bump versions and changelog for another pre-release * add git clean script * add exported flag to ActionBroadcastReceiver * add keep annotation to NotificationAction * lookup callback handler after flutter engine is initialised * fix error where plugin was lookup to the notification action callback and failed to find it as it was doing before the Flutter engine was initialised * Google Java Format * remove ActionBroadcastReceiverTest as implementation logic depends on starting Flutter engine * apply appropriate mutability flag to intents for notification actions to * Google Java Format * bump to 10.0.0-dev.8 * bump linux plugin * avoid trying to process iOS notification responses for notifications not created by the plugin (MaikuB#1509) * fix completionHandler being called for notifications created outside of the plugin * Clang Format * bump to 10.0.0-dev.9 Co-authored-by: runner <[email protected]> * update requestPermissions on macOS to have non-nullable parameters * fix default param values on macOS for requestPermissions * update 10.0.0-dev.9 changelog entry for macOS requestPermissions change * [flutter_local_notifications] adding ios/macos time sensitive interruption level (MaikuB#1501) * adding ios/macos time sensitive interruption level * adding ios/macos time sensitive interruption level * adding ios/macos time sensitive interruption level * darwin time sensitive notifications requested changes * darwin time sensitive notifications requested changes * fixing accidental revert of requrestPermission bool parameter defaults * fixing doc comment default value for `requestCriticalPermission` * Clang Format * change import used to get access to immutable annotation * update InterruptionLevel to use a class and be explicit on numeric values * bump to 10.0.0-dev.10 * fix api docs for InterruptionLevel * update example app to display groupKey of ActiveNotification * changelog and version bumps to prep for 10.0.0-dev.11 release * Reworked callbacks have separate callbacks to deal with foreground and background interactions (MaikuB#1548) * updated notification callbacks * update ios plugin code to deal with foreground notification actions * update notification app launch to process notification responses on ios * refactor code for extracting notification response dictionary on ios * update launch notification to be saved as a dictionary * update app launch notification logic on macos * rename and refactor notification logic on macos and ios * revert making didNotificationLaunchApp parameter named * update android plugin to send foreground event for notification actions * bump plugin and update changelog * Google Java Format * Swift Format * formatted objective c with clang format Co-authored-by: github-actions <> Co-authored-by: runner <[email protected]> * update logic on iOS and macOS to set notification categories without querying for existing categories (MaikuB#1549) * update logic to set notification categories without querying for existing categories * Swift Format Co-authored-by: runner <[email protected]> * add changelog entry on changes to setting notification categories * clarify notification actions support on Apple's platforms * updated readme to be more explicit around how to handle when is launched by a notification * remove reference to the word foreground from notification callback to avoid confusion (MaikuB#1555) * remove reference to the word foreground from notification callback to avoid confusion * Clang Format * add changelog entry for platform interface * update changelog entries and bump linux plugin Co-authored-by: runner <[email protected]> * fix linter issues in linux test class * bump linux plugin's dependency on platform interface * bump flutter_local_notifications dependencies on linux plugin and platform interface * suppress unchecked cast warnings in plugin * Google Java Format * bump to 10.0.0-dev.13 * bump to 10.0.0-dev.14 * fix merge issue * bump to 10.0.0-dev.15 * fix version which should be 10.0.0-dev.14 * fix progress in example app (MaikuB#1600) * [flutter_local_notifications] removed dependency on ThreeTenBP and use desugaring (MaikuB#1601) * remove ThreeTenBP and use Java desugaring * update example to app to use launchUrl instead of deprecated launch method * bump plugin and update changelog and readme on Gradle setup * add changelog entry for example app fix * add gradle setup to toc * fix version to 10.0.0-dev.14 * update changelog entry on version that it includes from stable release * remove extra bullet point in 10.0.0-dev.14 changelog entry * change linux plugin to now be a 1.0.0 pre-release instead * release 10.0.0-dev.15 * [flutter_local_notifications] add AndroidNotificationCategory to make Android categories more accessible (MaikuB#1609) * replace Android notification category String to AndroidNotificationCategory class type * change AndroidNotificationCategory to make use of const properties instead of factory constructors * add API docs for each Android category * format categories file * changed linux notification categories to static const fields instead of factory constructors * release 10.0.0-dev.16 * fix example app with using the email arrived linux notification category * release flutter_local_notifications 10.0.0-dev.17 * fix show with actions unit test * [flutter_local_notifications] Fix MaikuB#1654 (MaikuB#1655) * fix MaikuB#1654 * Google Java Format Co-authored-by: github-actions <> * add comment on why actionInputs has the nullable annotation * Google Java Format * release 10.0.0-dev.18 * release flutter_local_notification_linux 1.0.0-dev.3 * fix merge issue * bump for 10.0.0-dev.19 release * 10.0.0-dev.20 release * Google Java Format * fix unit test for notification actions to check for audioAttributesUsage * release flutter_local_notifications 10.0.0-dev.21 * bump minimum flutter sdk to 2.8 and minimum dart sdk to 2.15 * update changelog entry when mentioning dbus * [flutter_local_notification] update document MaikuB#1684 (MaikuB#1692) update IOS general setup document in flutter_local_notification/README.md * add annotation to solve tree-shaking issues when dealing with functions using background isolates * add more details on entry point annotation and wording tweaks to cavaets to using background isolates * update API docs for onDidReceiveBackgroundNotificationResponse to mention entry point annotation * remove references to IsolateNameServer APIs * update docs around callbacks * fix documentation on getActiveNotifications related code * update min flutter sdk version of flutter app to 2.8 * clean up example app * fix issues picked up by linter * add details on caveat on null notification payload * update versions for stable release * update changelog for stable release * add missing changelog entry for iOS and macOS on request critical notification permissions and specifying interruption level * add changelog entry on changes done to example app around notification IDs * remove url_launcher dependency as it's not longer used * add steps on setting up compile SDK version * remove excess blank line from changelog Co-authored-by: morvagergely <[email protected]> Co-authored-by: github-actions <> Co-authored-by: runner <[email protected]> Co-authored-by: runner <[email protected]> Co-authored-by: runner <[email protected]> Co-authored-by: runner <[email protected]> Co-authored-by: Yaroslav Pronin <[email protected]> Co-authored-by: runner <[email protected]> Co-authored-by: maprohu <[email protected]> Co-authored-by: runner <[email protected]> Co-authored-by: runner <[email protected]> Co-authored-by: runner <[email protected]> Co-authored-by: runner <[email protected]> Co-authored-by: Lucas Ribolli <[email protected]> Co-authored-by: SungHyun <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0144fa6 - Browse repository at this point
Copy the full SHA 0144fa6View commit details -
[flutter_local_notifications] use type safer intent APIs on Android A…
…PI 33+ (MaikuB#1705) * fix android deprecation warnings around intent APIs * Google Java Format * add suppress warnings annotation Co-authored-by: github-actions <>
Configuration menu - View commit details
-
Copy full SHA for cc9f2f8 - Browse repository at this point
Copy the full SHA cc9f2f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d829e3 - Browse repository at this point
Copy the full SHA 5d829e3View commit details -
[flutter_local_notifications] Update timezone (MaikuB#1706)
* Update timezone * update changelog and pubspec to add release info Co-authored-by: Michael Bui <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0e52442 - Browse repository at this point
Copy the full SHA 0e52442View commit details
Commits on Sep 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for adf9574 - Browse repository at this point
Copy the full SHA adf9574View commit details
Commits on Sep 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e291ba7 - Browse repository at this point
Copy the full SHA e291ba7View commit details
Commits on Sep 23, 2022
-
Crash fix when notification actions is used for foreground service (M…
…aikuB#1714) Making NotificationAction Serializable to support notification actions when notification is started as foreground service
Configuration menu - View commit details
-
Copy full SHA for 00ebd37 - Browse repository at this point
Copy the full SHA 00ebd37View commit details -
[flutter_local_notifications] update readme to include details of a F…
…lutter issue with desugaring enabled on foldable Android devices (MaikuB#1715) * update readme to include details of a Flutter issue with desugaring and foldable Android devices * bump to 11.0.1 * reword changelog entry on notification action fix with foreground service
Configuration menu - View commit details
-
Copy full SHA for 545f27b - Browse repository at this point
Copy the full SHA 545f27bView commit details -
[flutter_local_notifications] remove rxDart from example app and remo…
…ve unused dependency (MaikuB#1717) * remove unused shared_preferences dependency in example app * remove use of rxDart in example app * update changelog on cleaning up example app * reword changelog entry on example app cleanup to be more clearer
Configuration menu - View commit details
-
Copy full SHA for 6e342ae - Browse repository at this point
Copy the full SHA 6e342aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 48b7e63 - Browse repository at this point
Copy the full SHA 48b7e63View commit details
Commits on Sep 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3fdf27c - Browse repository at this point
Copy the full SHA 3fdf27cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d5035c - Browse repository at this point
Copy the full SHA 0d5035cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 168f9ba - Browse repository at this point
Copy the full SHA 168f9baView commit details
Commits on Sep 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for d2da530 - Browse repository at this point
Copy the full SHA d2da530View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58d987d - Browse repository at this point
Copy the full SHA 58d987dView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa90cdc - Browse repository at this point
Copy the full SHA aa90cdcView commit details