Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_local_notifications_linux] Add support for the file path icons #1602

Merged
merged 3 commits into from
Jun 4, 2022

Conversation

proninyaroslav
Copy link
Contributor

Adding the FilePathLinuxIcon class will allow the developer to specify a custom path in the file system to the icon, if other options, such as AssetsLinuxIcon, aren't suitable (for example, the assets path is different from the standard one).

Close #1565

@MaikuB
Copy link
Owner

MaikuB commented May 26, 2022

Thanks for updating the PR. Will review and test as soon as I can

@MaikuB
Copy link
Owner

MaikuB commented May 31, 2022

Thanks. LGTM but as mentioned in #1565, I'd like to see if @dballard could also give this a spin and provide feedback

@dballard
Copy link

dballard commented Jun 2, 2022

It appears good to me but I am struggling to test it in our app, I can adjust pubspec.lock to include a path to flutter_local_notifications but not flutter_local_notifications_linux because it's a dep by version of flutter_local_notifications.

But I think I now have code to use it, so if I still have problems I can always try following up with a PR now that the hard work is done! thanks!

@MaikuB
Copy link
Owner

MaikuB commented Jun 2, 2022

@dballard thanks for the update. I believe your issue could be solved using https://dart.dev/tools/pub/dependencies#dependency-overrides

@dballard
Copy link

dballard commented Jun 2, 2022

thanks @MaikuB that did the trick!
can confirm this works for our use case!
thank you so much @proninyaroslav this is awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AssetsLinuxIcon doesn't quite work as named
3 participants