-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter_local_notifications] Add support for Android Tiramisu' POST_NOTIFICATIONS
permission
#1658
[flutter_local_notifications] Add support for Android Tiramisu' POST_NOTIFICATIONS
permission
#1658
Conversation
POST_NOTIFICATION
permissionPOST_NOTIFICATIONS
permission
Locally Android integration tests pass when I use Flutter v3.0.5, but fail on Flutter v2.10.5. |
What's missing is returning a boolean result from |
Thanks for the PR, was going to comment that it looks like that was missing when it comes to dealing with the listener. Also the the Java code from the I'll take a closer look once the changes are done |
Also just remembered about flutter/flutter#12561 that can impact testing. A workaround is mentioned there |
@MaikuB Now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes. I've left some comments on this, hope they make sense and happy to discuss further if required
...d/src/main/java/com/dexterous/flutterlocalnotifications/FlutterLocalNotificationsPlugin.java
Outdated
Show resolved
Hide resolved
@MaikuB Thanks the for review, I'll make the changes soon :) |
...d/src/main/java/com/dexterous/flutterlocalnotifications/FlutterLocalNotificationsPlugin.java
Outdated
Show resolved
Hide resolved
Thanks for making the change. I pushed a grammar fix for the error message you added in so I can try to merge sooner. One thing that this made me think about though is the ability to use the existing |
Thank you for your help with getting this merged @MaikuB :) Regarding your idea with requesting permissions on |
No I'm referring to the plugin itself |
Thanks both for working on this! 👏🏻 Weighing in from the product side for requesting on |
If you look at how iOS/macOS works then there is control over that. This should be clearer if you look at the example app where it decides not to have permissions requested when calling |
Implements two new methods on
AndroidFlutterLocalNotificationsPlugin
,requestPermission
andisPermissionGranted
, to let developers work with the new notification runtime permission added in Android 13 Tiramisu (API level 33)Fixes #1597