Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_local_notifications] Add ActiveNotification.tag #1513

Merged
merged 1 commit into from
Mar 5, 2022

Conversation

emersion
Copy link
Contributor

@emersion emersion commented Mar 1, 2022

Allows users to fetch an active notification tag.

Closes: #1512

@emersion emersion changed the title Add ActiveNotification.tag [flutter_local_notifications] Add ActiveNotification.tag Mar 1, 2022
Copy link
Owner

@MaikuB MaikuB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I left a comment related to formatting but besides that, could you also update the example app so that the example that returns the active notification details would also display the tag?

@@ -7,6 +7,7 @@ class ActiveNotification {
this.channelId,
this.title,
this.body,
{ this.tag }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part of the code isn't formatted. Could you also a trailing comma and then apply formatting? This will mean adding a command after between tag and }

Allows users to fetch an active notification tag.

Closes: MaikuB#1512
@emersion
Copy link
Contributor Author

emersion commented Mar 3, 2022

All done, thanks for the review!

@MaikuB MaikuB merged commit f371695 into MaikuB:master Mar 5, 2022
@emersion emersion deleted the get-notif-tag branch March 5, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

android: add tag to getActiveNotifications
2 participants