-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter_local_notifications] Fix table of contents in README #1562
Conversation
Thanks for the PR and picking up on this. Maybe it's a GitHub issue but I'm having trouble making out what the changes are. Are you able to elaborate on what exactly changed. Here's what I see on GitHub so to my untrained eye, it looks the same though GitHub but there must be a difference if GitHub picked up on it How did you validate it worked on pub.dev too? Am I also right in saying that getting rid of emojis would completely get rid of the issue? I would assume so as emojis was a contibrution from @psyanite and I hadn't received reports of issues besides incorrect links prior to their addition. If this is causing issues then I would say it's better to remove the emojis so that the community can actually use the table of contents on both pub.dev and GitHub |
Hmm so it was a browser issue. I was using Safari and also checked Chrome on macOS. Given the inconsistent behaviour, do you think you'd be able to help look into either removing the emojis or seeing if there's a different set that would be suitable but would work on pub.dev and GitHub? |
I don't understand why GitHub is generating the # emoji within the link fragment. As it only happens for headings starting with the gear emoji, maybe we should just change that gear emoji? That way the two links would work on both platforms. |
Sure that was one of my suggestions so if you're able to find a suitable emoji and update the PR with it then I'd be happy to merge it in |
I swapped the gear for a wrench emoji. Now it works on GitHub and I don't see how it should not work on pub.dev. |
I also opened a bug report with GitHub. |
Thanks for this. Hopefully, pub.dev won't be the one with an issue with this :D |
This fixes the table of contents at https://pub.dev/packages/flutter_local_notifications .
Android and iOS Setup do not work as the emoji breaks the link fragment.
Unfortunately I just realized, that GitHub seems to handle the #️Number Sign emoji differently, so it currently only works on GitHub.
With this fix it would work on pub.dev, but not on GitHub. 😐