merge to latest version & fix issues in code review #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…macOS, Android (MaikuB#880)" (MaikuB#1477) This reverts commit 8e1ad8e.
…references (MaikuB#1478) * use apply to save to shared preferences * fix grammar and formatting issues in API docs for colorized property * bump plugin to 9.3.0 and update changelog
* remove dart:ffi import * fix changelog entry for dart:ffi fix
…e … (MaikuB#1492) * Updated all dependencies in flutter_local_notifications_linux to the last version * Reverted back to path dependency version 1.8.0 as it is incompatible with flutter_test * bump linux plugin version Co-authored-by: Michael Bui <[email protected]>
… with default values (MaikuB#1510) * fix crash on calling requestPermissions with default values * revert changes to example app
Allows users to fetch an active notification tag. Closes: MaikuB#1512
…ialize LocalNotification without per Platform settings (MaikuB#1559) * change: throw ArgumentError when trying to initialize LocalNotifications without per Platform settings add: tests * fix: typo * change: apply suggested changes add: new line in the readme change: the ArgumentError texts change: fix: capitalization of macOs change: apply text changes in the integration test change: make test case text more obvious * change: casing of macOS * formatting api docs per effective dart docs and bump plugin Co-authored-by: Michael Bui <[email protected]>
…consistency in readme (MaikuB#1571) * DST and function typo My understanding is that the best way of referring to DST is not "daylight savingS" but "daylight saving", and I put in "time" for completeness for a readme. https://en.wikipedia.org/wiki/Daylight_saving_time * Linearly changing header levels; consistent newlines Some headers were level 4 and 5 after a level 2 header, so I bumped them up. I removed extra newlines and added missing ones since most of the doc uses the style of 2 newlines after a header.
…try for docs updates
This allows fetching an active notification's MessagingStyleInformation. A typical use-case is appending a new Message to a MessagingStyle when receiving a push message.
…s on macOS (MaikuB#1590) * check if plugin should process notification * Swift Format * bump to 9.5.2 Co-authored-by: runner <[email protected]>
… onSelectNotification callback (MaikuB#1595)
…ons (MaikuB#1602) * Fix warnings on Flutter 3.0.0, upgrade dependencies * [Linux] Add support for the file path icons * [Linux] Add the file path icon to the example
…e or dateAndTime (MaikuB#1628)
…B#1641) * updated "Icon design status bar" link prev link redirects to material design > 404 * added archived label
…etNotificationAppLaunchDetails (MaikuB#1672) * updates how launch intent is read for getNotificationAppLaunchDetails * Google Java Format Co-authored-by: github-actions <>
…_NOTIFICATIONS` permission (MaikuB#1658) * implement Android side of `requestPermission` * implement Flutter side of `requestPermission` and `isPermissionGranted` * implement Android side of `isPermissionGranted` * clean up the big switch in `onMethodCall` * bump Android SDK version in example app's `build.gradle` * add `android.permission.POST_NOTIFICATIONS` to Manifest * remove `sourceCompatibility` and `targetCompatibility` which were added by mistake * remove `isPermissionGranted` – it is the same as `areNotificationsEnabled` * remove `isPermissionGranted` in Java code * return `bool` from Android's `requestPermission` debugging in progress * fighting * HAHAHAHAAHAH FIXED * cleanup * show whether notifications are enabled * add flag which prevents crashes when permissions are requested twice * remove code calling requestPermissions() twice * fail a `MethodCall` when another permission request is already in progress * fix grammar in error message when permission request is already in progress Co-authored-by: Michael Bui <[email protected]>
…notification on Android (MaikuB#1675) * add docs on request permission to show notification on Android * Google Java Format Co-authored-by: github-actions <>
…on changes needed for 9.8.0 (MaikuB#1677) * updated docs to mention compileSdkVersion changes needed for 9.8.0 * fix changelog and mention plugin's compileSdkVersion is now 33
…nDetails (MaikuB#1649) * Add audioAttributesUsage to NotificationDetails Allows users to change AudioAttributes (https://developer.android.com/reference/android/media/AudioAttributes) to the notification sound Closes: MaikuB#1519 * Adding null check when reading audioAttributesUsage in FlutterLocalNotificationsPlugin * Adding missing enum 'notificationRingtone' in AudioAttributesUsage's property, 'values'
…uB#1686) Other flutter plugins permissions requests can end up triggering onRequestPermissionsResult, so only handle callbacks when we're expecting one to be outstanding. This fixes a `java.lang.IllegalStateException: Reply already submitted` crash.
* Update pub.dev links Co-authored-by: Daniel Flores Medina <[email protected]> * Update pubspec.yaml Co-authored-by: Daniel Flores Medina <[email protected]>
…ations on iOS and macOS, iOS and macOS refactoring and renamed Android error codes (MaikuB#1406) * Added support for active notifications on iOS (MaikuB#1391) * Added support for active notifications on iOS * bump platform interface to 6.0.0-dev.1 for prerelease Co-authored-by: Michael Bui <[email protected]> * Google Java Format * fix version of platform interface * Swift Format * update error codes for unsupported os version and existing error codes to lower case * Swift Format * update groupKey changelog details * Clang Format * bump platform interface dependency used by linux plugin * bump linux plugin for prerelease * use dependency overrides for example app * update text in example app for getActiveNotifications example around unsupported iOS version * bump main plugin for prerelease * bump cross-platform facing plugin's dependency on linux plugin * call apply method for shared preferences editor instead of committing in background via a thread * fix linux plugin pubspec * update example to use device_info_plus instead of device_info * Clang Format * address linter issues * refactored iOS and macOS classes * update readme based on iOS/macOS refactoring and tweaks to docs around actions * fix section around handling notifications when app is in the foreground for iOS * updates for pre-release * add changelog entry on breaking change for refactoring iOS and macOS classes * bump platform interface dependency * rename callback for selecting notification action * rename method invoked from macos when action is selected * bump linux dependency * [flutter_local_notifications_linux] Add actions support in Linux (MaikuB#1442) * Add actions support in Linux * Update README * bump versions and changelog for another pre-release * add git clean script * add exported flag to ActionBroadcastReceiver * add keep annotation to NotificationAction * lookup callback handler after flutter engine is initialised * fix error where plugin was lookup to the notification action callback and failed to find it as it was doing before the Flutter engine was initialised * Google Java Format * remove ActionBroadcastReceiverTest as implementation logic depends on starting Flutter engine * apply appropriate mutability flag to intents for notification actions to * Google Java Format * bump to 10.0.0-dev.8 * bump linux plugin * avoid trying to process iOS notification responses for notifications not created by the plugin (MaikuB#1509) * fix completionHandler being called for notifications created outside of the plugin * Clang Format * bump to 10.0.0-dev.9 Co-authored-by: runner <[email protected]> * update requestPermissions on macOS to have non-nullable parameters * fix default param values on macOS for requestPermissions * update 10.0.0-dev.9 changelog entry for macOS requestPermissions change * [flutter_local_notifications] adding ios/macos time sensitive interruption level (MaikuB#1501) * adding ios/macos time sensitive interruption level * adding ios/macos time sensitive interruption level * adding ios/macos time sensitive interruption level * darwin time sensitive notifications requested changes * darwin time sensitive notifications requested changes * fixing accidental revert of requrestPermission bool parameter defaults * fixing doc comment default value for `requestCriticalPermission` * Clang Format * change import used to get access to immutable annotation * update InterruptionLevel to use a class and be explicit on numeric values * bump to 10.0.0-dev.10 * fix api docs for InterruptionLevel * update example app to display groupKey of ActiveNotification * changelog and version bumps to prep for 10.0.0-dev.11 release * Reworked callbacks have separate callbacks to deal with foreground and background interactions (MaikuB#1548) * updated notification callbacks * update ios plugin code to deal with foreground notification actions * update notification app launch to process notification responses on ios * refactor code for extracting notification response dictionary on ios * update launch notification to be saved as a dictionary * update app launch notification logic on macos * rename and refactor notification logic on macos and ios * revert making didNotificationLaunchApp parameter named * update android plugin to send foreground event for notification actions * bump plugin and update changelog * Google Java Format * Swift Format * formatted objective c with clang format Co-authored-by: github-actions <> Co-authored-by: runner <[email protected]> * update logic on iOS and macOS to set notification categories without querying for existing categories (MaikuB#1549) * update logic to set notification categories without querying for existing categories * Swift Format Co-authored-by: runner <[email protected]> * add changelog entry on changes to setting notification categories * clarify notification actions support on Apple's platforms * updated readme to be more explicit around how to handle when is launched by a notification * remove reference to the word foreground from notification callback to avoid confusion (MaikuB#1555) * remove reference to the word foreground from notification callback to avoid confusion * Clang Format * add changelog entry for platform interface * update changelog entries and bump linux plugin Co-authored-by: runner <[email protected]> * fix linter issues in linux test class * bump linux plugin's dependency on platform interface * bump flutter_local_notifications dependencies on linux plugin and platform interface * suppress unchecked cast warnings in plugin * Google Java Format * bump to 10.0.0-dev.13 * bump to 10.0.0-dev.14 * fix merge issue * bump to 10.0.0-dev.15 * fix version which should be 10.0.0-dev.14 * fix progress in example app (MaikuB#1600) * [flutter_local_notifications] removed dependency on ThreeTenBP and use desugaring (MaikuB#1601) * remove ThreeTenBP and use Java desugaring * update example to app to use launchUrl instead of deprecated launch method * bump plugin and update changelog and readme on Gradle setup * add changelog entry for example app fix * add gradle setup to toc * fix version to 10.0.0-dev.14 * update changelog entry on version that it includes from stable release * remove extra bullet point in 10.0.0-dev.14 changelog entry * change linux plugin to now be a 1.0.0 pre-release instead * release 10.0.0-dev.15 * [flutter_local_notifications] add AndroidNotificationCategory to make Android categories more accessible (MaikuB#1609) * replace Android notification category String to AndroidNotificationCategory class type * change AndroidNotificationCategory to make use of const properties instead of factory constructors * add API docs for each Android category * format categories file * changed linux notification categories to static const fields instead of factory constructors * release 10.0.0-dev.16 * fix example app with using the email arrived linux notification category * release flutter_local_notifications 10.0.0-dev.17 * fix show with actions unit test * [flutter_local_notifications] Fix MaikuB#1654 (MaikuB#1655) * fix MaikuB#1654 * Google Java Format Co-authored-by: github-actions <> * add comment on why actionInputs has the nullable annotation * Google Java Format * release 10.0.0-dev.18 * release flutter_local_notification_linux 1.0.0-dev.3 * fix merge issue * bump for 10.0.0-dev.19 release * 10.0.0-dev.20 release * Google Java Format * fix unit test for notification actions to check for audioAttributesUsage * release flutter_local_notifications 10.0.0-dev.21 * bump minimum flutter sdk to 2.8 and minimum dart sdk to 2.15 * update changelog entry when mentioning dbus * [flutter_local_notification] update document MaikuB#1684 (MaikuB#1692) update IOS general setup document in flutter_local_notification/README.md * add annotation to solve tree-shaking issues when dealing with functions using background isolates * add more details on entry point annotation and wording tweaks to cavaets to using background isolates * update API docs for onDidReceiveBackgroundNotificationResponse to mention entry point annotation * remove references to IsolateNameServer APIs * update docs around callbacks * fix documentation on getActiveNotifications related code * update min flutter sdk version of flutter app to 2.8 * clean up example app * fix issues picked up by linter * add details on caveat on null notification payload * update versions for stable release * update changelog for stable release * add missing changelog entry for iOS and macOS on request critical notification permissions and specifying interruption level * add changelog entry on changes done to example app around notification IDs * remove url_launcher dependency as it's not longer used * add steps on setting up compile SDK version * remove excess blank line from changelog Co-authored-by: morvagergely <[email protected]> Co-authored-by: github-actions <> Co-authored-by: runner <[email protected]> Co-authored-by: runner <[email protected]> Co-authored-by: runner <[email protected]> Co-authored-by: runner <[email protected]> Co-authored-by: Yaroslav Pronin <[email protected]> Co-authored-by: runner <[email protected]> Co-authored-by: maprohu <[email protected]> Co-authored-by: runner <[email protected]> Co-authored-by: runner <[email protected]> Co-authored-by: runner <[email protected]> Co-authored-by: runner <[email protected]> Co-authored-by: Lucas Ribolli <[email protected]> Co-authored-by: SungHyun <[email protected]>
…PI 33+ (MaikuB#1705) * fix android deprecation warnings around intent APIs * Google Java Format * add suppress warnings annotation Co-authored-by: github-actions <>
* Update timezone * update changelog and pubspec to add release info Co-authored-by: Michael Bui <[email protected]>
"Darwom" to "Darwin"
…aikuB#1714) Making NotificationAction Serializable to support notification actions when notification is started as foreground service
…lutter issue with desugaring enabled on foldable Android devices (MaikuB#1715) * update readme to include details of a Flutter issue with desugaring and foldable Android devices * bump to 11.0.1 * reword changelog entry on notification action fix with foreground service
…ve unused dependency (MaikuB#1717) * remove unused shared_preferences dependency in example app * remove use of rxDart in example app * update changelog on cleaning up example app * reword changelog entry on example app cleanup to be more clearer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: MaikuB#1473 (review)
In this PR, I made the plugin support specifying guid. And can pass raw XML to the plugin. Also fixed the ERROR_INVALID_PARAMETER issue.