Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_local_notifications] Documentation: updated dead link #1641

Merged
merged 2 commits into from
Jul 6, 2022

Conversation

zopagaduanjr
Copy link
Contributor

Icon design status bar's previous link redirects to material design > 404.

replaced it with this archived icon_design_status_bar page

prev link redirects to material design > 404
@MaikuB
Copy link
Owner

MaikuB commented Jul 6, 2022

Thanks for the fix. As the page being linked to appears to be archived, could a note to mention this perhaps added too? I believe were meant to have redirects in place to point the latest version and the developer documentation currently still points to the same link the readme currently has (see https://developer.android.com/studio/write/image-asset-studio#notification). With this mind, the issue may be something Google had missed when updating their docs too

@MaikuB
Copy link
Owner

MaikuB commented Jul 6, 2022

Thanks for making the change. Will merge this in. For future reference, in case you intend to contribute more to OSS, I suggest you create a separate branch in your fork rather than committing your changes to the default branch (main/master). This makes it easier to keep your fork to to date when the original/upstream repo/branch has changes and you want to keep your fork up to date

@MaikuB MaikuB merged commit 0b20a45 into MaikuB:master Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants