Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_local_notifications] Update gson package for vulnerabilities #1593

Merged
merged 1 commit into from
May 14, 2022

Conversation

briannaAndCo
Copy link
Contributor

Fixes CVE-2022-25647.

This updates an android jar to a version without the vulnerability. Vulnerability is considered HIGH and more info is here

@MaikuB
Copy link
Owner

MaikuB commented May 13, 2022

Thanks a lot for the PR. I noticed there's 2.9.0 that was out in February so curious if you know there's a why 2.9.0 shouldn't be used instead. Not following the development of gson but as you knew about this issue i thought I'd ask in case you might know

@briannaAndCo
Copy link
Contributor Author

I picked 1.8.9 because it's the first version without the vulnerability. And while I know jumping minor versions shouldn't cause issues, it sometimes can in my experience, so it seemed safer to stay with the same minor version if possible.

@MaikuB
Copy link
Owner

MaikuB commented May 13, 2022

Thanks that was my guess but wanted to check

@MaikuB MaikuB merged commit 621e6ff into MaikuB:master May 14, 2022
@briannaAndCo briannaAndCo deleted the briannaAndCo-cve-fix branch May 16, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants