Change AudioAttributes to the notifications in android #1519
Comments
|
A PR would be welcome but would like know what the thought would be on how users of the plugin specify the attribute? If you're looking to expand this then I suspect it makes sense to allow any of the allowed attribute values to be specified then for backwards compatibility, assume the default value is |
|
Cool! Even though it does not really make any sense to specify some of the attributes available in Guess I'll start working on a PR that in the coming weeks branching of 10.0.0? |
|
This sounds like something that wouldn't be a breaking change so if that's the case, it could use master as the target branch so that this goes out in a 9.x release |
Allows users to change AudioAttributes (https://developer.android.com/reference/android/media/AudioAttributes) to the notification sound Closes: MaikuB#1519
Allows users to change AudioAttributes (https://developer.android.com/reference/android/media/AudioAttributes) to the notification sound Closes: MaikuB#1519
…nDetails (MaikuB#1649) * Add audioAttributesUsage to NotificationDetails Allows users to change AudioAttributes (https://developer.android.com/reference/android/media/AudioAttributes) to the notification sound Closes: MaikuB#1519 * Adding null check when reading audioAttributesUsage in FlutterLocalNotificationsPlugin * Adding missing enum 'notificationRingtone' in AudioAttributesUsage's property, 'values'
…nDetails (MaikuB#1649) * Add audioAttributesUsage to NotificationDetails Allows users to change AudioAttributes (https://developer.android.com/reference/android/media/AudioAttributes) to the notification sound Closes: MaikuB#1519 * Adding null check when reading audioAttributesUsage in FlutterLocalNotificationsPlugin * Adding missing enum 'notificationRingtone' in AudioAttributesUsage's property, 'values'
…nDetails (#1649) * Add audioAttributesUsage to NotificationDetails Allows users to change AudioAttributes (https://developer.android.com/reference/android/media/AudioAttributes) to the notification sound Closes: MaikuB/flutter_local_notifications#1519 * Adding null check when reading audioAttributesUsage in FlutterLocalNotificationsPlugin * Adding missing enum 'notificationRingtone' in AudioAttributesUsage's property, 'values'
…nDetails (#1649) * Add audioAttributesUsage to NotificationDetails Allows users to change AudioAttributes (https://developer.android.com/reference/android/media/AudioAttributes) to the notification sound Closes: MaikuB/flutter_local_notifications#1519 * Adding null check when reading audioAttributesUsage in FlutterLocalNotificationsPlugin * Adding missing enum 'notificationRingtone' in AudioAttributesUsage's property, 'values'
Hello @MaikuB 👋
First of all, thank you so much for the plugin! Huge fan!
Have a use case where we would like to change AudioAttributes for the notifications here:
flutter_local_notifications/flutter_local_notifications/android/src/main/java/com/dexterous/flutterlocalnotifications/FlutterLocalNotificationsPlugin.java
Line 953 in 2c0b2db
Specifically to
AudioAttributes.USAGE_ALARMWe are maintaining a fork so there is no problem for us just change the attribute, but I was wondering if there would be any interest in adding this to AndroidNotificationDetails?
If so, I would be happy to write a PR
The text was updated successfully, but these errors were encountered: