[flutter_local_notifications] Add audioAttributesUsage to NotificationDetails #1649
Conversation
bornold
changed the title
There was a problem hiding this comment.
Thanks for the PR. It looks like the code is missing some logic to handle how there could be scheduled notification that would have values for the new fields added on the Java/Android side. This means changes need to be added to fallback to say the audio usage is for notifications. Without this, what would happen is a scheduled notification is deserialised from shared preferences and a NPE would occur
Allows users to change AudioAttributes (https://developer.android.com/reference/android/media/AudioAttributes) to the notification sound Closes: MaikuB#1519
bornold
force-pushed
the
android-audio-attributes-usage
branch
from
2df4fa1
to
4726ae1
Compare
| if (notificationDetails.audioAttributesUsage == null) { | ||
| notificationDetails.audioAttributesUsage = AudioAttributes.USAGE_NOTIFICATION; | ||
| } |
There was a problem hiding this comment.
Not sure if this should null checks or not, can revert if it is unnecessary
There was a problem hiding this comment.
The null checks you've added aren't necessary as the Dart/Flutter API won't allow this to happen. The issue I mentioned in my previous message can still occur so this can be reverted (i.e. this isn't the location where the problem can occur). I'll point out exactly where the issue I mentioned can be resolved in a separate comment
| @@ -972,7 +972,7 @@ private static void setupNotificationChannel( | |||
| notificationChannel.setGroup(notificationChannelDetails.groupId); | |||
| if (notificationChannelDetails.playSound) { | |||
| AudioAttributes audioAttributes = | |||
| new AudioAttributes.Builder().setUsage(AudioAttributes.USAGE_NOTIFICATION).build(); | |||
| new AudioAttributes.Builder().setUsage(notificationChannelDetails.audioAttributesUsage).build(); | |||
There was a problem hiding this comment.
This is the place to coalesce a null value from a scheduled notification to AudioAttributes.USAGE_NOTIFICATION
…tificationsPlugin
bornold
force-pushed
the
android-audio-attributes-usage
branch
from
e9d4d2e
to
a139479
Compare
...d/src/main/java/com/dexterous/flutterlocalnotifications/FlutterLocalNotificationsPlugin.java
Show resolved
Hide resolved
flutter_local_notifications/lib/src/platform_specifics/android/enums.dart
Show resolved
Hide resolved
…property, 'values'
…nDetails (MaikuB#1649) * Add audioAttributesUsage to NotificationDetails Allows users to change AudioAttributes (https://developer.android.com/reference/android/media/AudioAttributes) to the notification sound Closes: MaikuB#1519 * Adding null check when reading audioAttributesUsage in FlutterLocalNotificationsPlugin * Adding missing enum 'notificationRingtone' in AudioAttributesUsage's property, 'values'
…nDetails (MaikuB#1649) * Add audioAttributesUsage to NotificationDetails Allows users to change AudioAttributes (https://developer.android.com/reference/android/media/AudioAttributes) to the notification sound Closes: MaikuB#1519 * Adding null check when reading audioAttributesUsage in FlutterLocalNotificationsPlugin * Adding missing enum 'notificationRingtone' in AudioAttributesUsage's property, 'values'
Allows users to change AudioAttributes (https://developer.android.com/reference/android/media/AudioAttributes) to the notification sound
Closes: #1519