[5.3] Versioning table column fix#46007
Closed
bembelimen wants to merge 182 commits intojoomla:5.3-devfrom
Closed
Conversation
[5.4] Set initial version and code name
…2-28 [5.4] Upmerge changes from 5.3-dev 2025-02-28
…3-04 [5.4] Upmerge changes from 5.3-dev 2025-03-04
[5.4] upmerge 2025-03-11
- Use the JS ESM module instead of the iife - Drop the patches in the build tools
…3-16 [5.4] Upmerge changes from 5.3-dev 2025-03-16
[5.4] upmerge 2025-03-18
[5.4] upmerge 2025-03-25
…3-26 [5.4] Upmerge changes from 5.3-dev 2025-03-26
Co-authored-by: Tuan Pham Ngoc <github@joomdonation.com>
…4-01 [5.4] Upmerge changes from 5.3-dev 2025-04-01
* [5.3] Remove pointless boolean expressions Co-authored-by: Tuan Pham Ngoc <github@joomdonation.com> Co-authored-by: Quy Ton <quy@nomonkeybiz.com>
Smart Search module creates new Query and triggers `Joomla\Component\Finder\Administrator\Indexer::processString()` method which loads available taxonomy branch titles via separate SQL query per each module (duplicate query). We should not process empty string, when the module is loaded without any input. Plus, `Taxonomy::getBranchTitles()` load should use static cache and produce only single query to prevent duplicate when we have multiple mod_finder instances (i.e. typical case for Yootheme templates where one module is rendered in header and second in mobile dialog).
joomla#45644) * Remove use of deprecated dispatcher
Small tweak to the label of this option and add a description Signed-off-by: BrianTeeman <brian@teeman.net>
Fix default upload folder to be same as Media "Path to Images Folder" option.
This PR adds a new plugin event that allows 3rd party extensions to stop automatted updates. This allows 3rd party developers to i.e. enforce special conditions like "only perform auto updates if a backup using my backup extension has been performed in the last 24h". Furthermore, this PR also fixed the version number in the "failed update" notfication that is sent when an update is blocked by a plugin. Side note: A new "after update" event is not required, as the default after update event will be called.
* Convert update infourl into legacy data format
[5.4] Upmerge 2025-08-26
* Revert "[5.4] Replace deprecation AbstractView::get() in layouts (joomla#45702)" * This reverts commit f1906ba.
* [5.3] Translation Update joomla#45983 * [5.3] Fix copy / paste error in form fields joomla#45979 * [5.3] Security updates for composer and npm dependencies for the upcoming 5.3.4 release joomla#45984 * [5.3] Update joomla/filesystem to fix extension uploads when post_max_size is 0 joomla#45986
--------- Co-authored-by: Brian Teeman <brian@teeman.net> Co-authored-by: Heiko Lübbe <github@heikol.de> Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
bembelimen
requested review from
Hackwar,
chmst,
laoneo and
rdeutz
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
With #45597 checked_out + checked_out_time are set when restoring a version history. But this code is assuming that every extension is using this fields. This PR makes checks if the field exist and uses the proper alias.
Testing Instructions
See the testing instruction in #45597 it should still work the same.
Actual result BEFORE applying this Pull Request
Hard coded way of resetting fields
Expected result AFTER applying this Pull Request
Date&User are still reset when fields are there but in a flexible way.