Merged
Conversation
During the build process off a new release or update we remove various files that should not or do not need to be distributed This PR extends the list of files to be removed from the libraries/vendor folder to include .drone.yml .drone.jsonnet Examples can be seen in most of the libraries/vendor/joomla folders Signed-off-by: BrianTeeman <brian@teeman.net> Co-authored-by: Quy Ton <quy@nomonkeybiz.com>
Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
* Update php-tuf to version 5.3 * revert composer change
_this is an AI generated explanation_ The warning Only the first byte will be assigned to the string offset occurs because $temp1 is being treated as a string, and assigning a value to $temp1[$i] attempts to modify a specific character (byte) of the string. However, the value being assigned (random_int(0, 99999999)) is an integer, which is incompatible with this operation. Root Cause: In PHP, when you use array-like syntax (e.g., $temp1[$i]) on a variable that has not been explicitly declared as an array, PHP may treat it as a string. In this case, $temp1 is being treated as a string, and $temp1[$i] is interpreted as modifying a specific character of the string. Since random_int(0, 99999999) generates an integer, PHP raises a warning because you cannot assign an integer to a specific byte of a string. Fix: To resolve this issue, you need to explicitly declare $temp1 as an array before using it. This ensures that $temp1[$i] is treated as an array element rather than a string offset. Explanation of the Fix: Explicit Declaration: $temp1 = []; ensures that $temp1 is treated as an array from the start. This avoids PHP's automatic type juggling, which might treat $temp1 as a string if it is not explicitly declared. Assigning Values: $temp1[$i] = random_int(0, 99999999); now correctly assigns the random integer to the $ith index of the $temp1 array. Summary: This fix ensures that $temp1 is treated as an array, eliminating the warning and allowing the code to function as intended. Signed-off-by: BrianTeeman <brian@teeman.net>
Don't use the deprecated CMS Filesystem but the framework package
PHP Deprecated: strtotime(): Passing null to parameter #1 ($datetime) of type string is deprecated Signed-off-by: BrianTeeman <brian@teeman.net>
joomla-backports/json-api-php#3 Fixes deprecation notices Signed-off-by: BrianTeeman <brian@teeman.net>
joomla-cms-bot
added
Composer Dependency Changed
NPM Resource Changed
richard67
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weekly upmerge from 5.3-dev branch to 5.4-dev.