[5.4] Adjust status code of com_joomlaupdate APIs if automated updates are disabled

[SniperSister]

Pull Request for Issue #45962

Summary of Changes

Throw a 404 instead of a 500

Testing Instructions

• Install 5.4.0-beta1 on public available site
• Make sure that autoupdates are disabled
• Using a http client of choice, perform a request against /api/index.php/v1/joomlaupdate/healthcheck

Actual result BEFORE applying this Pull Request

500 thrown

Expected result AFTER applying this Pull Request

404 thrown

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[HLeithner]

409 would fit better I think

[SniperSister]

... and I think that the general error handling of the JsonapiRenderer needs a serious refactoring as it's currently impossible to define an status code from an application level, you have to rely on the pre-defined handlers and their hardcoded codes.

[richard67]

Hmm, 409 indeed seems more suitable than 404.

[SniperSister]

As I said: the API does not allow custom status codes. Specific exceptions are associated with specific codes. We would have to add a new exception type for a 409, which just builds yet another layer on this insufficient base design. I’m not doing this in my PR. Either use it or propose an alternate approach.

[richard67]

I'm ok with that. As the Rolling Stones sang: You can't always get what you want :-)

[cybersalt]

I have tested this item ✅ successfully on 0cd8e66

Received a 404 after the patch.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45966.}

[exlemor]

I have tested this item ✅ successfully on 0cd8e66

I have tested this successfully with Tim ;) Thanks @SniperSister!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45966.}

[rbuelund]

I have tested this item ✅ successfully on 0cd8e66

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45966.}

[muhme]

✅ Final test before merge, using public instance with manual installation

• before the PR

curl -H 'X-JUpdate-Token: 4711' 'https://joomla-test.heikol.de/api/index.php/v1/joomlaupdate/healthcheck'
{"errors":[{"code":500,"title":"Internal server error"}]}%  

• After second installation with this PR from full package:
  {"errors":[{"title":"Resource not found","code":404}]}%

[muhme]

Thank you @SniperSister for your contribution. Thank you @HLeithner and @richard67 for supporting this issue. Thank you @rbuelund and @exlemor for testing.