[5.4] Replace deprecation AbstractView::get() in layouts

[heelc29]

Summary of Changes

remove deprecated access to AbstractView::get() for layout files

@Hackwar as negative side effect #44162 the access to protected properties of the view class is no longer possible. Is that acceptable?

joomla-cms/libraries/src/MVC/View/AbstractView.php

Lines 175 to 177 in 8868adc

	if (isset($this->$property)) {
	return $this->$property;
	}

Testing Instructions

check views still working eg.

• banner edit view (backend)
• admin module edit view (backend)
• categories view of contact, content, newsfeeds (frontend)
• category view of contact, content, newsfeeds (frontend)

Actual result BEFORE applying this Pull Request

deprecated access to method get of AbstractView

Expected result AFTER applying this Pull Request

no deprecated access to method get of AbstractView

Link to documentations

Please select:

• No documentation changes for docs.joomla.org needed
• No documentation changes for manual.joomla.org needed

[exlemor]

I have tested this item ✅ successfully on 60d1379

I have tested this successfully.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45702.}

[hans2103]

I have tested this item ✅ successfully on 60d1379

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45702.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45702.}

[muhme]

Final test before merge, before applying this PR, with JBT graft Joomla_5.4.0-alpha4-dev-Development-Full_Package.zip, used links are listed – IDs needs to be picked-up from backend:

• Renamed all uncategorised to Content-Uncategorised, Banners-Uncategorised and Contacts-Uncategorised
• Created one article, one banner, one contact and one news feed entry
• Banner edit view (backend)
  • Components > Banners > Banners > First Banner
• Admin module edit view (backend)
  • System > Administrator Modules > Sample Data
• Categories view of contact, content, newsfeeds (frontend w/o login)
  • /index.php?option=com_contact&view=categories
  • /index.php?option=com_content&view=categories
  • /index.php?option=com_newsfeeds&view=categories
• Category view of contact, content, newsfeeds (frontend w/o login)
  • /index.php?option=com_contact&view=category&id=4
  • /index.php?option=com_content&view=category&id=2
  • /index.php?option=com_newsfeeds&view=category&id=5
    • ⚠️ Page contains a broken link to the /index.php/component/newsfeeds/newsfeed/first-news-feed?catid=5

Tested with this PR by graft Joomla_5.4.0-alpha4-dev+pr.45702-Development-Full_Package.zip:

• ✅ Tested all the backend views, including editing
• ✅ Tested all the frontend views, including the links in the views
• ✅ The previous broken link is now working

[muhme]

Thank you @heelc29 for your contribution and @Hackwar for your code review. Thank you @exlemor and @hans2103 for testing.

[brianteeman]

This has broken com_guidedtours so clearly it is a b/c break which should not happen in a minor release and must be reverted and moved to j6 see #45938