Skip to content

[5.4] Cleanup short and sweet script#45017

Merged
richard67 merged 6 commits intojoomla:5.4-devfrom
dgrammatiko:5.3-dev/js/short
Mar 14, 2025
Merged

[5.4] Cleanup short and sweet script#45017
richard67 merged 6 commits intojoomla:5.4-devfrom
dgrammatiko:5.3-dev/js/short

Conversation

@dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Feb 26, 2025

Pull Request for Issue # .

Summary of Changes

  • Use the JS ESM module instead of the iife
  • Drop the patches in the build tools

Testing Instructions

  • Run npm ci or download and install joomla from the PR
  • Create a new article and check that the Meta Description field (under the publishing tab) updates the remaining characters as you type

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev labels Feb 26, 2025
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 756fffe


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45017.

@Fedik Fedik added the Feature label Mar 6, 2025
@ghost
Copy link

ghost commented Mar 6, 2025

I have tested this item ✅ successfully on 756fffe

Remaining characters are updated like before.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45017.

@Fedik
Copy link
Member

Fedik commented Mar 6, 2025

r2c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45017.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 6, 2025
@rdeutz
Copy link
Contributor

rdeutz commented Mar 8, 2025

I think it is fine to do this in 5.4, wouldn't do it at this stage in 5.3. It's more a cleanup then a feature but this is up to the ReleaseManager for 5.4. I will rebase it.

@rdeutz rdeutz changed the title [5.3] Cleanup short and sweet script [5.4] Cleanup short and sweet script Mar 8, 2025
@rdeutz rdeutz changed the base branch from 5.3-dev to 5.4-dev March 8, 2025 16:32
@rdeutz rdeutz added RMDQ ReleaseManagerDecisionQueue PR-5.4-dev and removed Feature PR-5.3-dev labels Mar 8, 2025
@richard67 richard67 removed the RMDQ ReleaseManagerDecisionQueue label Mar 14, 2025
@richard67 richard67 merged commit ec9034a into joomla:5.4-dev Mar 14, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 14, 2025
@richard67
Copy link
Member

Thanks all.

@richard67 richard67 added this to the Joomla! 5.4.0 milestone Mar 14, 2025
@dgrammatiko dgrammatiko deleted the 5.3-dev/js/short branch March 14, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.4-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants