[5.4] Convert TUF update info URL into legacy format#45980
[5.4] Convert TUF update info URL into legacy format#45980muhme merged 4 commits intojoomla:5.4-devfrom
Conversation
|
@SniperSister I am trying to test this PR but your 1st step says: Download /install: Joomla_5.4.0-beta2-dev+pr.45696-Development-Full_Package.zip, except that PR: I found this https://artifacts.joomla.org/drone/joomla/joomla-cms/5.4-dev/45696/downloads/87417/ For others looking for the 2 plugins: What PHP warning is expected? |
See the fixed issue and maybe from there the tested PR. |
|
I have tested this item 🔴 unsuccessfully on 4fdaf73
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45980. |
|
Fixed @muhme - sorry, my bad, did not commit the final version |
|
I have tested this item ✅ successfully on 58742e1
Thank you @SniperSister This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45980. |
|
I have tested this item ✅ successfully on 58742e1 Thanks @SniperSister for the PR and fixes :) This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45980. |
|
Unfortunately, I'm too late, as I just noticed. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45980. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45980. |
|
Thank you @SniperSister for your contribution. Thank you @richard67 for your support. Thank you @exlemor for testing. |
Pull Request for Issue #45977
Summary of Changes
The legacy update XML format used a XML attribute per infourl, wheras the JSON-based TUF is using two separate keys. That leads to a different data structure, that had to be converted - this PR adds the conversion logic.
Testing Instructions
Actual result BEFORE applying this Pull Request
PHP Warning
Expected result AFTER applying this Pull Request
No warning
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed