[5.4] Skip version infos for potential downgrades in TUF#45964
[5.4] Skip version infos for potential downgrades in TUF#45964muhme merged 3 commits intojoomla:5.4-devfrom
Conversation
|
I have tested this item 🔴 unsuccessfully on 77c1e5c Sorry ;( @SniperSister) followed your instructions and had another PBF tester watching. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45964. |
|
I have tested this item 🔴 unsuccessfully on 77c1e5c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45964. |
|
I have tested this item 🔴 unsuccessfully on 77c1e5c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45964. |
|
You all know that you have to search again for updates after having applied the patch? The version will not change by only applying the patch. |
Yes, that's what I did, but PHP 8.1 is still being displayed as minimum requirement. |
|
I have tested this item 🔴 unsuccessfully on 77c1e5c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45964. |
|
@brianteeman @exlemor @cybersalt @crimle thanks for testing, I was able to find the root cause if the issue and fix it - please have another look |
|
I have tested this item ✅ successfully on f88b78e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45964. |
|
I have tested this item ✅ successfully on f88b78e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45964. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45964. |
|
✅ Final test before merge, with JBT graft and the needed MariaDB 10.6 update (which was not required before this PR) 👍 |
|
Thank you @SniperSister for your contribution. Thank you @exlemor, @cybersalt, @crimle and @brianteeman for testing. |
Pull Request for Issue #45954 #45953
Summary of Changes
This PR fixes an edge case scenario:
So far, the code that is handling potential TUF updates was checking if the currently processed update information would offer an update that's newer than the previously processed update. However, for the very first offered updated, there was no compare target and therefore it was always considered as potential candidate.
That caused issues with the "special update" to 5.1.2 that's currently included in the 6.x branch in the TUF repo to handle a bug in the early 5.1.0 and 5.1.1 releases.
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed