Skip to content

[5.4] Skip version infos for potential downgrades in TUF#45964

Merged
muhme merged 3 commits intojoomla:5.4-devfrom
SniperSister:5.4-skip-tuf-downgrade-info
Aug 23, 2025
Merged

[5.4] Skip version infos for potential downgrades in TUF#45964
muhme merged 3 commits intojoomla:5.4-devfrom
SniperSister:5.4-skip-tuf-downgrade-info

Conversation

@SniperSister
Copy link
Contributor

@SniperSister SniperSister commented Aug 22, 2025

Pull Request for Issue #45954 #45953

Summary of Changes

This PR fixes an edge case scenario:
So far, the code that is handling potential TUF updates was checking if the currently processed update information would offer an update that's newer than the previously processed update. However, for the very first offered updated, there was no compare target and therefore it was always considered as potential candidate.

That caused issues with the "special update" to 5.1.2 that's currently included in the 6.x branch in the TUF repo to handle a bug in the early 5.1.0 and 5.1.1 releases.

Testing Instructions

  • Install Joomla 5.4.0-beta1
  • Switch to the "Next" update channel and select beta as stability
  • Fetch update information
  • Apply patch
  • Repeat

Actual result BEFORE applying this Pull Request

  • Joomla 6.0.0 beta 1 discovered, but minimum PHP version of 8.1 shown as requirement - because that's the min version of the 5.1.2 release:
Bildschirmfoto 2025-08-23 um 13 29 11

Expected result AFTER applying this Pull Request

  • Min PHP version of 8.3 shown

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@exlemor
Copy link

exlemor commented Aug 23, 2025

I have tested this item 🔴 unsuccessfully on 77c1e5c

I have tested this from 2 installations and were unsuccessful in both (Rochen test site and my own hosting).

Sorry ;( @SniperSister) followed your instructions and had another PBF tester watching.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45964.

@cybersalt
Copy link

I have tested this item 🔴 unsuccessfully on 77c1e5c

PHP 8.1.0 still showing after that patch was applied.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45964.

@crimle
Copy link

crimle commented Aug 23, 2025

I have tested this item 🔴 unsuccessfully on 77c1e5c

Still min PHP version of 8.1 shown as requirement


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45964.

@richard67
Copy link
Member

You all know that you have to search again for updates after having applied the patch? The version will not change by only applying the patch.

@crimle
Copy link

crimle commented Aug 23, 2025

You all know that you have to search again for updates after having applied the patch? The version will not change by only applying the patch.

Yes, that's what I did, but PHP 8.1 is still being displayed as minimum requirement.

@brianteeman
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on 77c1e5c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45964.

@SniperSister
Copy link
Contributor Author

@brianteeman @exlemor @cybersalt @crimle thanks for testing, I was able to find the root cause if the issue and fix it - please have another look

@exlemor
Copy link

exlemor commented Aug 23, 2025

I have tested this item ✅ successfully on f88b78e

Hi @SniperSister, yes indeed you found the issue ;) I have tested this successfully! :) Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45964.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on f88b78e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45964.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45964.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 23, 2025
@muhme
Copy link
Contributor

muhme commented Aug 23, 2025

✅ Final test before merge, with JBT graft and the needed MariaDB 10.6 update (which was not required before this PR) 👍

@muhme muhme merged commit 989dae9 into joomla:5.4-dev Aug 23, 2025
40 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 23, 2025
@muhme muhme removed the PBF Pizza, Bugs and Fun label Aug 23, 2025
@muhme muhme added this to the Joomla! 5.4.0 milestone Aug 23, 2025
@muhme
Copy link
Contributor

muhme commented Aug 23, 2025

Thank you @SniperSister for your contribution. Thank you @exlemor, @cybersalt, @crimle and @brianteeman for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants