[5.4] Remove pointless boolean expressions

[janschoenherr]

Remove pointless boolean expressions reported by PhpStorm inspections.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[QuyTon]

I have tested this item ✅ successfully on 196f28d

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44885.}

[komalm]

I have tested this item ✅ successfully on ec8cc4b

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44885.}

[QuyTon]

@janschoenherr Please fix conflicts. Thanks!

[QuyTon]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44885.}

[HLeithner]

For the moment we don't want to merge this change, we will discuss this in the next maintainer meeting.

[joomdonation]

Thanks for your hard work. I did a code review and see some changes needed. Please see below in each comment (please look at each suggested change carefully and make sure you are agree with the change before committing the suggested change)

[rdeutz]

Thanks @joomdonation for the code review, I agree that's the way to go.

[joomdonation]

I have tested this item ✅ successfully on 3bf56c2

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44885.}

[joomdonation]

@QuyTon Could you please give this another (hopefully final) review?

[QuyTon]

I have tested this item ✅ successfully on 3bf56c2

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44885.}

[QuyTon]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44885.}

[richard67]

As agreed today in the maintainers meeting, I've rebased this PR to 5.4-dev.

[laoneo]

I really like the improvements work as done in this pr. Unfortunately I fear that it might lead to regressions when that amount of files are touched. If possible it should be split into smaller pieces. When it still is intended to be merged as a whole, then this should be done very early in the 5.4 release cycle to iron out potential regressions. Just my 2cent's.

Has been discussed and rebased meanwhile.

[muhme]

Thanks all