Remove "history may be shared" banner. by kaylendog · Pull Request #31881 · element-hq/element-web

kaylendog · 2026-01-26T13:23:36Z

This banner is too annoying and invasive, so we are removing it. Oh well!

Checklist

I have read through review guidelines and CONTRIBUTING.md.
Tests written for new code (and old code if feasible).
New or updated public/exported symbols have accurate TSDoc documentation.
Linter and other CI checks pass.
I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

kaylendog · 2026-01-26T15:20:25Z

test/test-utils/test-utils.ts

@@ -30,9 +29,9 @@ import {
    JoinRule,
    type OidcClientConfig,
    type GroupCall,
-    HistoryVisibility,
-    type ICreateRoomOpts,
    type EventStatus,
+    type ICreateRoomOpts,
+    RoomState,


These changes seem a little extraneous, but it's where ESLint wants to put them.

This reverts commit ce9c66b.

… VM. (#31545)" This reverts commit 4da149e.

…31535)" This reverts commit c7134e8.

This reverts commit cff9119.

florianduros · 2026-01-26T17:17:24Z

playwright/snapshots/crypto/history-sharing.spec.ts/shared-history-invite-accepted-linux.png

So what's the point of this screenshot?

I have restored the screenshot to the expected result produced by the test introduced in #30948. I believe the intention is to make sure a message is decryptable in an E2E environment.

…880) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [element-hq/element-web](https://github.com/element-hq/element-web) | patch | `v1.12.9` → `v1.12.10` | --- ### Release Notes <details> <summary>element-hq/element-web (element-hq/element-web)</summary> ### [`v1.12.10`](https://github.com/element-hq/element-web/releases/tag/v1.12.10) [Compare Source](element-hq/element-web@v1.12.9...v1.12.10) #### ✨ Features - Support additional\_creators in /upgraderoom (MSC4289) ([#31934](element-hq/element-web#31934)). Contributed by [@andybalaam](https://github.com/andybalaam). - Update room header icon for world\_readable rooms ([#31915](element-hq/element-web#31915)). Contributed by [@richvdh](https://github.com/richvdh). - Show an icon in the room header for shared history ([#31879](element-hq/element-web#31879)). Contributed by [@richvdh](https://github.com/richvdh). - Remove "history may be shared" banner. ([#31881](element-hq/element-web#31881)). Contributed by [@kaylendog](https://github.com/kaylendog). - Allow dismissing 'Key storage out of sync' temporarily ([#31455](element-hq/element-web#31455)). Contributed by [@andybalaam](https://github.com/andybalaam). - Add `resolutions` entry for `matrix-widget-api` to package.json ([#31851](element-hq/element-web#31851)). Contributed by [@toger5](https://github.com/toger5). - Improve visibility under contrast control mode ([#31847](element-hq/element-web#31847)). Contributed by [@t3chguy](https://github.com/t3chguy). - Unread Sorting - Add option for sorting in `OptionsMenuView` ([#31754](element-hq/element-web#31754)). Contributed by [@MidhunSureshR](https://github.com/MidhunSureshR). - Unread sorting - Implement sorter and use it in the room list store ([#31723](element-hq/element-web#31723)). Contributed by [@MidhunSureshR](https://github.com/MidhunSureshR). - Allow Element Call widgets to receive sticky events ([#31843](element-hq/element-web#31843)). Contributed by [@robintown](https://github.com/robintown). - Improve icon rendering accessibility ([#31791](element-hq/element-web#31791)). Contributed by [@t3chguy](https://github.com/t3chguy). - Add message preview toggle to room list header option ([#31821](element-hq/element-web#31821)). Contributed by [@florianduros](https://github.com/florianduros). #### 🐛 Bug Fixes - \[Backport staging] Fix room list not being cleared ([#32438](element-hq/element-web#32438)). Contributed by [@RiotRobot](https://github.com/RiotRobot). - Fix failure to update room info panel on joinrule change ([#31938](element-hq/element-web#31938)). Contributed by [@richvdh](https://github.com/richvdh). - Throttle space notification state calculation ([#31922](element-hq/element-web#31922)). Contributed by [@dbkr](https://github.com/dbkr). - Fix emoji verification responsive layout ([#31899](element-hq/element-web#31899)). Contributed by [@t3chguy](https://github.com/t3chguy). - Add patch for linkify to fix doctype handling ([#31900](element-hq/element-web#31900)). Contributed by [@dbkr](https://github.com/dbkr). - Fix rooms with no messages appearing at the top of the room list ([#31798](element-hq/element-web#31798)). Contributed by [@MidhunSureshR](https://github.com/MidhunSureshR). - Fix room list menu flashes when menu is closed ([#31868](element-hq/element-web#31868)). Contributed by [@florianduros](https://github.com/florianduros). - Message preview toggle is inverted in room list header ([#31865](element-hq/element-web#31865)). Contributed by [@florianduros](https://github.com/florianduros). - Fix duplicate toasts appearing for the same call if two events appear. ([#31693](element-hq/element-web#31693)). Contributed by [@Half-Shot](https://github.com/Half-Shot). - Fix ability to send rageshake during session restore failure ([#31848](element-hq/element-web#31848)). Contributed by [@t3chguy](https://github.com/t3chguy). - Fix mis-alignment of `Threads` right panel title ([#31849](element-hq/element-web#31849)). Contributed by [@t3chguy](https://github.com/t3chguy). - Unset buttons does not include color inherit ([#31801](element-hq/element-web#31801)). Contributed by [@Philldomd](https://github.com/Philldomd). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/3880 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>

kaylendog self-assigned this Jan 26, 2026

github-actions bot deployed to Netlify January 26, 2026 13:27 View deployment

kaylendog force-pushed the kaylendog/history-sharing/remove-banner branch from de5a526 to f9b5b31 Compare January 26, 2026 13:29

kaylendog added the T-Deprecation A pull request that makes something deprecated label Jan 26, 2026

github-actions bot deployed to Netlify January 26, 2026 13:32 View deployment

kaylendog added T-Enhancement and removed T-Deprecation A pull request that makes something deprecated labels Jan 26, 2026

github-actions bot deployed to Netlify January 26, 2026 13:36 View deployment

github-actions bot deployed to EndToEndTests January 26, 2026 13:52 View deployment

kaylendog commented Jan 26, 2026

View reviewed changes

github-actions bot deployed to EndToEndTests January 26, 2026 15:30 View deployment

kaylendog force-pushed the kaylendog/history-sharing/remove-banner branch from c5d204b to ed3ea34 Compare January 26, 2026 16:48

github-actions bot deployed to Netlify January 26, 2026 16:52 View deployment

kaylendog force-pushed the kaylendog/history-sharing/remove-banner branch from ed3ea34 to d49a3f7 Compare January 26, 2026 16:52

github-actions bot deployed to Netlify January 26, 2026 16:55 View deployment

github-actions bot requested a deployment to EndToEndTests January 26, 2026 17:10 Abandoned

kaylendog marked this pull request as ready for review January 26, 2026 17:10

kaylendog requested a review from a team as a code owner January 26, 2026 17:10

kaylendog requested review from MidhunSureshR and florianduros January 26, 2026 17:10

kaylendog added 4 commits January 26, 2026 17:10

Revert "Update algorithm for history visible banner. (#31577)"

11b1fdb

This reverts commit ce9c66b.

Revert "Update prop type & documentation for HistoryVisibleBanner and…

7a717a2

… VM. (#31545)" This reverts commit 4da149e.

Revert "Prevent history visible banner from displaying in threads. (#…

96bac6f

…31535)" This reverts commit c7134e8.

Revert "Implement UI for history visibility acknowledgement. (#31156)"

9eae11a

This reverts commit cff9119.

kaylendog force-pushed the kaylendog/history-sharing/remove-banner branch from d49a3f7 to 9eae11a Compare January 26, 2026 17:10

github-actions bot deployed to Netlify January 26, 2026 17:14 View deployment

florianduros reviewed Jan 26, 2026

View reviewed changes

github-actions bot deployed to EndToEndTests January 26, 2026 17:27 View deployment

kaylendog requested a review from florianduros January 26, 2026 18:11

florianduros approved these changes Jan 27, 2026

View reviewed changes

kaylendog added this pull request to the merge queue Jan 27, 2026

Merged via the queue into develop with commit d0c60e6 Jan 27, 2026
41 of 43 checks passed

kaylendog deleted the kaylendog/history-sharing/remove-banner branch January 27, 2026 11:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove "history may be shared" banner.#31881

Remove "history may be shared" banner.#31881
kaylendog merged 4 commits intodevelopfrom
kaylendog/history-sharing/remove-banner

kaylendog commented Jan 26, 2026

Uh oh!

kaylendog Jan 26, 2026

Uh oh!

florianduros Jan 26, 2026

Uh oh!

kaylendog Jan 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

kaylendog commented Jan 26, 2026

Checklist

Uh oh!

kaylendog Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

florianduros Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

kaylendog Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants