Playwright test for history sharing on invite#30948
Merged
Conversation
richvdh
force-pushed
the
rav/share_history_on_invite_playwright
branch
from
0fecae6 to
cf3c8fd
Compare
Helper function to fish a room ID out of the URL
Pick up the extended `Credentials` interface that was added in element-hq/element-modules#80.
richvdh
force-pushed
the
rav/share_history_on_invite_playwright
branch
2 times, most recently
from
33d10a2 to
ffedfc4
Compare
element-hq/element-modules#81 added a utility function for building and routing `config.json`; we should use it.
richvdh
force-pushed
the
rav/share_history_on_invite_playwright
branch
from
ffedfc4 to
497454b
Compare
richvdh
force-pushed
the
rav/share_history_on_invite_playwright
branch
from
497454b to
cc86d0f
Compare
richvdh
force-pushed
the
rav/share_history_on_invite_playwright
branch
from
cc86d0f to
2a62deb
Compare
richvdh
force-pushed
the
rav/share_history_on_invite_playwright
branch
from
2a62deb to
331f8a8
Compare
florianduros
requested changes
Oct 7, 2025
playwright/pages/ElementAppPage.ts
Outdated
Comment on lines
221
to
222
| await this.page.locator(".mx_BaseCard").getByRole("menuitem", { name: "Invite" }).click(); | ||
| const inviteDialog = this.page.locator(".mx_InviteDialog_other"); |
Member
There was a problem hiding this comment.
We shouldn't use css class as playwright selector
Comment on lines
48
to
55
| await bobPage.locator(".mx_RoomView").getByRole("button", { name: "Accept" }).click(); | ||
|
|
||
| // Bob should now be able to decrypt the event | ||
| const roomViewBody = bobPage.locator(".mx_RoomView_body"); | ||
| await expect(roomViewBody.getByText("A message from Alice")).toBeVisible(); | ||
|
|
||
| const mask = [bobPage.locator(".mx_MessageTimestamp")]; | ||
| await expect(bobPage.locator(".mx_RoomView_body")).toMatchScreenshot("shared-history-invite-accepted.png", { |
Member
There was a problem hiding this comment.
We shouldn't use css class as playwright selector
Member
Author
There was a problem hiding this comment.
I've done what I can to avoid these. It's hard to avoid for the screenshot because I want a screenshot of the whole timeline and I can't find a better selector.
uhoreg
approved these changes
Oct 7, 2025
florianduros
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-meta#2920