Fix failure to update room info panel on joinrule change #31938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if the join rules are updated, the room info panel is not updated until the panel is re-rendered. This is due to a misuse of `useRoomState`.
t3chguy
approved these changes
Feb 2, 2026
This hook is useless without a `mapper` function, so let's mandate it. Also improve the documentation while we're here.
richvdh
force-pushed
the
rav/fix_use_room_state_usage
branch
from
dddbd77 to
b6a87a6
Compare
rbondesson
pushed a commit
to ZacksBot/element-web
that referenced
this pull request
Feb 3, 2026
…31938) * Fix failure to update room info panel on joinrule change Currently, if the join rules are updated, the room info panel is not updated until the panel is re-rendered. This is due to a misuse of `useRoomState`. * Update documentation and types on `useRoomState` This hook is useless without a `mapper` function, so let's mandate it. Also improve the documentation while we're here.
alexlebens
pushed a commit
to alexlebens/infrastructure
that referenced
this pull request
Feb 10, 2026
…880) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [element-hq/element-web](https://github.com/element-hq/element-web) | patch | `v1.12.9` → `v1.12.10` | --- ### Release Notes <details> <summary>element-hq/element-web (element-hq/element-web)</summary> ### [`v1.12.10`](https://github.com/element-hq/element-web/releases/tag/v1.12.10) [Compare Source](element-hq/element-web@v1.12.9...v1.12.10) #### ✨ Features - Support additional\_creators in /upgraderoom (MSC4289) ([#​31934](element-hq/element-web#31934)). Contributed by [@​andybalaam](https://github.com/andybalaam). - Update room header icon for world\_readable rooms ([#​31915](element-hq/element-web#31915)). Contributed by [@​richvdh](https://github.com/richvdh). - Show an icon in the room header for shared history ([#​31879](element-hq/element-web#31879)). Contributed by [@​richvdh](https://github.com/richvdh). - Remove "history may be shared" banner. ([#​31881](element-hq/element-web#31881)). Contributed by [@​kaylendog](https://github.com/kaylendog). - Allow dismissing 'Key storage out of sync' temporarily ([#​31455](element-hq/element-web#31455)). Contributed by [@​andybalaam](https://github.com/andybalaam). - Add `resolutions` entry for `matrix-widget-api` to package.json ([#​31851](element-hq/element-web#31851)). Contributed by [@​toger5](https://github.com/toger5). - Improve visibility under contrast control mode ([#​31847](element-hq/element-web#31847)). Contributed by [@​t3chguy](https://github.com/t3chguy). - Unread Sorting - Add option for sorting in `OptionsMenuView` ([#​31754](element-hq/element-web#31754)). Contributed by [@​MidhunSureshR](https://github.com/MidhunSureshR). - Unread sorting - Implement sorter and use it in the room list store ([#​31723](element-hq/element-web#31723)). Contributed by [@​MidhunSureshR](https://github.com/MidhunSureshR). - Allow Element Call widgets to receive sticky events ([#​31843](element-hq/element-web#31843)). Contributed by [@​robintown](https://github.com/robintown). - Improve icon rendering accessibility ([#​31791](element-hq/element-web#31791)). Contributed by [@​t3chguy](https://github.com/t3chguy). - Add message preview toggle to room list header option ([#​31821](element-hq/element-web#31821)). Contributed by [@​florianduros](https://github.com/florianduros). #### 🐛 Bug Fixes - \[Backport staging] Fix room list not being cleared ([#​32438](element-hq/element-web#32438)). Contributed by [@​RiotRobot](https://github.com/RiotRobot). - Fix failure to update room info panel on joinrule change ([#​31938](element-hq/element-web#31938)). Contributed by [@​richvdh](https://github.com/richvdh). - Throttle space notification state calculation ([#​31922](element-hq/element-web#31922)). Contributed by [@​dbkr](https://github.com/dbkr). - Fix emoji verification responsive layout ([#​31899](element-hq/element-web#31899)). Contributed by [@​t3chguy](https://github.com/t3chguy). - Add patch for linkify to fix doctype handling ([#​31900](element-hq/element-web#31900)). Contributed by [@​dbkr](https://github.com/dbkr). - Fix rooms with no messages appearing at the top of the room list ([#​31798](element-hq/element-web#31798)). Contributed by [@​MidhunSureshR](https://github.com/MidhunSureshR). - Fix room list menu flashes when menu is closed ([#​31868](element-hq/element-web#31868)). Contributed by [@​florianduros](https://github.com/florianduros). - Message preview toggle is inverted in room list header ([#​31865](element-hq/element-web#31865)). Contributed by [@​florianduros](https://github.com/florianduros). - Fix duplicate toasts appearing for the same call if two events appear. ([#​31693](element-hq/element-web#31693)). Contributed by [@​Half-Shot](https://github.com/Half-Shot). - Fix ability to send rageshake during session restore failure ([#​31848](element-hq/element-web#31848)). Contributed by [@​t3chguy](https://github.com/t3chguy). - Fix mis-alignment of `Threads` right panel title ([#​31849](element-hq/element-web#31849)). Contributed by [@​t3chguy](https://github.com/t3chguy). - Unset buttons does not include color inherit ([#​31801](element-hq/element-web#31801)). Contributed by [@​Philldomd](https://github.com/Philldomd). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4zLjYiLCJ1cGRhdGVkSW5WZXIiOiI0My4zLjYiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsImltYWdlIl19--> Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/3880 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the join rules are updated, the room info panel is not updated until the panel is re-rendered. This is due to a misuse of
useRoomState.Also fix the documentation and types on
useRoomState.