Update prop type & documentation for HistoryVisibleBanner and VM.#31545
Merged
kaylendog merged 5 commits intoelement-hq:developfrom Dec 17, 2025
Merged
Conversation
richvdh
requested changes
Dec 15, 2025
richvdh
requested changes
Dec 17, 2025
kaylendog
changed the title
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
kaylendog
force-pushed
the
kaylendog/history-sharing/banner-docs
branch
from
2c9b87a to
d8caef4
Compare
kaylendog
force-pushed
the
kaylendog/history-sharing/banner-docs
branch
from
d8caef4 to
69978ad
Compare
richvdh
approved these changes
Dec 17, 2025
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
LGTM otherwise. Feel free to merge after fixing these nits
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 27, 2026
* Revert "Update algorithm for history visible banner. (#31577)" This reverts commit ce9c66b. * Revert "Update prop type & documentation for HistoryVisibleBanner and VM. (#31545)" This reverts commit 4da149e. * Revert "Prevent history visible banner from displaying in threads. (#31535)" This reverts commit c7134e8. * Revert "Implement UI for history visibility acknowledgement. (#31156)" This reverts commit cff9119.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.