Show an icon in the room header for shared history #31879

richvdh · 2026-01-26T12:06:20Z

Add a decoration to the header for encrypted rooms with history_visibility: {shared|public}.

Screenshot:

Add a decoration to the header for encrypted rooms with `history_visibility: {shared|public}`. Fixes: #31858

t3chguy

Isn't this still behind a feature flag feature_share_history_on_invite? Also isn't it misleading given new members which self-join will not see history. I think this needs product sign-off

Also as per the e2e test fails, looks a bit scary on DMs, no?

richvdh · 2026-01-26T13:34:56Z

Isn't this still behind a feature flag feature_share_history_on_invite? Also isn't it misleading given new members which self-join will not see history. I think this needs product sign-off

I'll double-check these.

Also as per the e2e test fails, looks a bit scary on DMs, no?

What do you mean?

t3chguy · 2026-01-26T14:00:21Z

What do you mean?

Just like we hide the member list in a 2-user DM, I doubt we want to scare people into thinking others may be able to see your secret chat with BotAlice in the future.

richvdh · 2026-01-26T14:49:22Z

I doubt we want to scare people into thinking others may be able to see your secret chat with BotAlice in the future.

The whole point of the icon is to let people know that others may be able to see your secret chat with BotAlice in the future.

t3chguy · 2026-01-26T14:50:57Z

The whole point of a member list is to see who is in the room, we still hide it from the room header for DMs as product/design deemed it confusing for users for DMs

mxandreas

From product/design - this is intentional. We want to highlight to the ex-WhatsApp people that new members can read history (which is never the case on WhatsApp). And it is true that some existing Element users may need to be warned as well, as they might have history sharing accidentally on.

t3chguy · 2026-01-26T15:05:56Z

But today it simply won't be true? As it shows without the labs flag enabled, and also the joiner may not be joining in a compatible way?

If the joiner isn't using Element
If the joiner self-joins (e.g. via restricted join rule)
If the joiner is using Element but without the labs flag on

So it makes it feel like a broken feature if anything? Oversell and disappoint shouldn't be the UX imo

mxandreas · 2026-01-26T15:24:52Z

From product/design - this is intentional. We want to highlight to the ex-WhatsApp people that new members can read history (which is never the case on WhatsApp). And it is true that some existing Element users may need to be warned as well, as they might have history sharing accidentally on.

mxandreas · 2026-01-26T15:35:48Z

But today it simply won't be true? As it shows without the labs flag enabled, and also the joiner may not be joining in a compatible way?

We should check the labs flag, yes, because that is straightforward to do.

If the joiner isn't using Element
If the joiner self-joins (e.g. via restricted join rule)

It is not ideal, but I do not see this as a major issue as the warning is to make sure user is aware of the current policy. Making the tooltip more complex/nuanced usually does not help and makes it even more complicated to understand. We can improve this by linking the FAQ entry for this if there will be significant confusion.

... since history isn't actually shared unless the flag is on

…_icon

andybalaam

Looks good, thanks!

t3chguy · 2026-01-27T15:08:20Z

playwright/e2e/crypto/history-sharing.spec.ts


-            const mask = [bobPage.locator(".mx_MessageTimestamp")];
+            // Exclude message timestamps and RR avatars from the screenshot. Bob sometimes sees Alice's RR on the
+            // previous event, which is surprising but not what we're testing here.


This sounds like you're introducing a flaky test as per my comment c1d5f1a

css is what you want rather than mask to hide things you want excluded from a screenshot due to inconsistent position, rather than inconsistent content which is what a mask helps with

I'm afraid I can't see your comment there.

It seems like it was already flaky, because it passed in CI and failed on my machine. Given it still passes in CI, having updated the screenshot on my machine, I hope this has made it less flaky.

I think if anything it'd make it more flaky, as it makes it vary more rather than less, by the size difference between the circle and the square mask. Though, likely both are enough to trigger the min pixels difference check

Followup on #31879: change the icon shown for world_readable rooms.

Followup on element-hq#31879: change the icon shown for world_readable rooms.

…880) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [element-hq/element-web](https://github.com/element-hq/element-web) | patch | `v1.12.9` → `v1.12.10` | --- ### Release Notes <details> <summary>element-hq/element-web (element-hq/element-web)</summary> ### [`v1.12.10`](https://github.com/element-hq/element-web/releases/tag/v1.12.10) [Compare Source](element-hq/element-web@v1.12.9...v1.12.10) #### ✨ Features - Support additional\_creators in /upgraderoom (MSC4289) ([#31934](element-hq/element-web#31934)). Contributed by [@andybalaam](https://github.com/andybalaam). - Update room header icon for world\_readable rooms ([#31915](element-hq/element-web#31915)). Contributed by [@richvdh](https://github.com/richvdh). - Show an icon in the room header for shared history ([#31879](element-hq/element-web#31879)). Contributed by [@richvdh](https://github.com/richvdh). - Remove "history may be shared" banner. ([#31881](element-hq/element-web#31881)). Contributed by [@kaylendog](https://github.com/kaylendog). - Allow dismissing 'Key storage out of sync' temporarily ([#31455](element-hq/element-web#31455)). Contributed by [@andybalaam](https://github.com/andybalaam). - Add `resolutions` entry for `matrix-widget-api` to package.json ([#31851](element-hq/element-web#31851)). Contributed by [@toger5](https://github.com/toger5). - Improve visibility under contrast control mode ([#31847](element-hq/element-web#31847)). Contributed by [@t3chguy](https://github.com/t3chguy). - Unread Sorting - Add option for sorting in `OptionsMenuView` ([#31754](element-hq/element-web#31754)). Contributed by [@MidhunSureshR](https://github.com/MidhunSureshR). - Unread sorting - Implement sorter and use it in the room list store ([#31723](element-hq/element-web#31723)). Contributed by [@MidhunSureshR](https://github.com/MidhunSureshR). - Allow Element Call widgets to receive sticky events ([#31843](element-hq/element-web#31843)). Contributed by [@robintown](https://github.com/robintown). - Improve icon rendering accessibility ([#31791](element-hq/element-web#31791)). Contributed by [@t3chguy](https://github.com/t3chguy). - Add message preview toggle to room list header option ([#31821](element-hq/element-web#31821)). Contributed by [@florianduros](https://github.com/florianduros). #### 🐛 Bug Fixes - \[Backport staging] Fix room list not being cleared ([#32438](element-hq/element-web#32438)). Contributed by [@RiotRobot](https://github.com/RiotRobot). - Fix failure to update room info panel on joinrule change ([#31938](element-hq/element-web#31938)). Contributed by [@richvdh](https://github.com/richvdh). - Throttle space notification state calculation ([#31922](element-hq/element-web#31922)). Contributed by [@dbkr](https://github.com/dbkr). - Fix emoji verification responsive layout ([#31899](element-hq/element-web#31899)). Contributed by [@t3chguy](https://github.com/t3chguy). - Add patch for linkify to fix doctype handling ([#31900](element-hq/element-web#31900)). Contributed by [@dbkr](https://github.com/dbkr). - Fix rooms with no messages appearing at the top of the room list ([#31798](element-hq/element-web#31798)). Contributed by [@MidhunSureshR](https://github.com/MidhunSureshR). - Fix room list menu flashes when menu is closed ([#31868](element-hq/element-web#31868)). Contributed by [@florianduros](https://github.com/florianduros). - Message preview toggle is inverted in room list header ([#31865](element-hq/element-web#31865)). Contributed by [@florianduros](https://github.com/florianduros). - Fix duplicate toasts appearing for the same call if two events appear. ([#31693](element-hq/element-web#31693)). Contributed by [@Half-Shot](https://github.com/Half-Shot). - Fix ability to send rageshake during session restore failure ([#31848](element-hq/element-web#31848)). Contributed by [@t3chguy](https://github.com/t3chguy). - Fix mis-alignment of `Threads` right panel title ([#31849](element-hq/element-web#31849)). Contributed by [@t3chguy](https://github.com/t3chguy). - Unset buttons does not include color inherit ([#31801](element-hq/element-web#31801)). Contributed by [@Philldomd](https://github.com/Philldomd). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/3880 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>

Show an icon in the room header for shared history

6c42c8a

Add a decoration to the header for encrypted rooms with `history_visibility: {shared|public}`. Fixes: #31858

richvdh requested a review from a team as a code owner January 26, 2026 12:06

richvdh requested review from florianduros and t3chguy January 26, 2026 12:06

richvdh added the T-Enhancement label Jan 26, 2026

github-actions bot deployed to Netlify January 26, 2026 12:09 View deployment

github-actions bot deployed to EndToEndTests January 26, 2026 12:23 View deployment

t3chguy reviewed Jan 26, 2026

View reviewed changes

t3chguy requested a review from a team January 26, 2026 12:40

mxandreas reviewed Jan 26, 2026

View reviewed changes

mxandreas closed this Jan 26, 2026

mxandreas reopened this Jan 26, 2026

github-actions bot deployed to Netlify January 26, 2026 15:28 View deployment

github-actions bot deployed to EndToEndTests January 26, 2026 15:41 View deployment

Gate "shared history icon" behind labs flag

95a7f84

... since history isn't actually shared unless the flag is on

github-actions bot deployed to Netlify January 26, 2026 17:10 View deployment

github-actions bot deployed to EndToEndTests January 26, 2026 17:24 View deployment

Update snapshots

8832660

github-actions bot deployed to Netlify January 27, 2026 11:39 View deployment

github-actions bot deployed to EndToEndTests January 27, 2026 11:52 View deployment

richvdh added 3 commits January 27, 2026 12:27

update screenshot

f9d24c5

Merge remote-tracking branch 'origin/develop' into rav/shared_history…

de74ab0

…_icon

update screenshots, again

8984de7

github-actions bot deployed to Netlify January 27, 2026 12:54 View deployment

github-actions bot deployed to EndToEndTests January 27, 2026 13:07 View deployment

exclude RRs from screenshot test

c1d5f1a

richvdh requested a review from a team as a code owner January 27, 2026 13:27

richvdh requested a review from andybalaam January 27, 2026 13:27

github-actions bot deployed to Netlify January 27, 2026 13:30 View deployment

github-actions bot deployed to EndToEndTests January 27, 2026 13:43 View deployment

github-actions bot deployed to EndToEndTests January 27, 2026 14:06 View deployment

andybalaam approved these changes Jan 27, 2026

View reviewed changes

richvdh added this pull request to the merge queue Jan 27, 2026

t3chguy reviewed Jan 27, 2026

View reviewed changes

Merged via the queue into develop with commit 6177220 Jan 27, 2026
48 of 50 checks passed

richvdh deleted the rav/shared_history_icon branch January 27, 2026 15:25

richvdh added a commit that referenced this pull request Jan 29, 2026

Update room header icon for world_readable rooms

144837d

Followup on #31879: change the icon shown for world_readable rooms.

richvdh mentioned this pull request Jan 29, 2026

Update room header icon for world_readable rooms #31915

Merged

BillCarsonFr pushed a commit that referenced this pull request Jan 29, 2026

Update room header icon for world_readable rooms (#31915)

24018f7

Followup on #31879: change the icon shown for world_readable rooms.

rbondesson pushed a commit to ZacksBot/element-web that referenced this pull request Feb 3, 2026

Update room header icon for world_readable rooms (element-hq#31915)

48864bc

Followup on element-hq#31879: change the icon shown for world_readable rooms.

Uh oh!

Show an icon in the room header for shared history #31879

Show an icon in the room header for shared history #31879

Uh oh!

Conversation

richvdh commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

t3chguy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

richvdh commented Jan 26, 2026

Uh oh!

t3chguy commented Jan 26, 2026

Uh oh!

richvdh commented Jan 26, 2026

Uh oh!

t3chguy commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mxandreas left a comment

Choose a reason for hiding this comment

Uh oh!

t3chguy commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mxandreas commented Jan 26, 2026

Uh oh!

mxandreas commented Jan 26, 2026

Uh oh!

andybalaam left a comment

Choose a reason for hiding this comment

Uh oh!

t3chguy Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

richvdh Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

t3chguy Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

richvdh commented Jan 26, 2026 •

edited

Loading

t3chguy left a comment •

edited

Loading

t3chguy commented Jan 26, 2026 •

edited

Loading

t3chguy commented Jan 26, 2026 •

edited

Loading

t3chguy Jan 27, 2026 •

edited

Loading

t3chguy Jan 29, 2026 •

edited

Loading