Skip to content

Conversation

@MidhunSureshR
Copy link
Member

@MidhunSureshR MidhunSureshR commented Jan 20, 2026

Fixes #30602

  • Copies over code from the old RLS
  • Remove deprecated js-sdk calls
  • When you can't find an event in the timeline from which to get a timestamp, return 0 as the timestamp so that the room is pushed to the bottom of the list.

@MidhunSureshR MidhunSureshR force-pushed the midhun/roomlist-2/fix-purged-rooms branch from 6140265 to 678531d Compare January 26, 2026 14:18
@MidhunSureshR MidhunSureshR changed the title Extract and move getLastTs from older RLS to new RLSv3 Fix rooms with no messages appearing at the top of the room list Jan 26, 2026
@MidhunSureshR MidhunSureshR force-pushed the midhun/roomlist-2/fix-purged-rooms branch from 678531d to 1e1e7c0 Compare January 26, 2026 15:00
@MidhunSureshR MidhunSureshR force-pushed the midhun/roomlist-2/fix-purged-rooms branch from 1e1e7c0 to 6944ddd Compare January 27, 2026 14:02
@MidhunSureshR MidhunSureshR force-pushed the midhun/roomlist-2/fix-purged-rooms branch from 6944ddd to f031906 Compare January 27, 2026 14:33
@MidhunSureshR MidhunSureshR force-pushed the midhun/roomlist-2/fix-purged-rooms branch from f031906 to 29e589c Compare January 27, 2026 14:49
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane, in future though please keep the "copy code" and "modify code" commits separate, you made the bug fix/functional change in the first commit which also copied the code which made the review harder than it needed to be

@MidhunSureshR MidhunSureshR added this pull request to the merge queue Jan 27, 2026
Merged via the queue into develop with commit dda87ff Jan 27, 2026
48 checks passed
@MidhunSureshR MidhunSureshR deleted the midhun/roomlist-2/fix-purged-rooms branch January 27, 2026 16:40
alexlebens pushed a commit to alexlebens/infrastructure that referenced this pull request Feb 10, 2026
…880)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [element-hq/element-web](https://github.com/element-hq/element-web) | patch | `v1.12.9` → `v1.12.10` |

---

### Release Notes

<details>
<summary>element-hq/element-web (element-hq/element-web)</summary>

### [`v1.12.10`](https://github.com/element-hq/element-web/releases/tag/v1.12.10)

[Compare Source](element-hq/element-web@v1.12.9...v1.12.10)

#### ✨ Features

- Support additional\_creators in /upgraderoom (MSC4289) ([#&#8203;31934](element-hq/element-web#31934)). Contributed by [@&#8203;andybalaam](https://github.com/andybalaam).
- Update room header icon for world\_readable rooms ([#&#8203;31915](element-hq/element-web#31915)). Contributed by [@&#8203;richvdh](https://github.com/richvdh).
- Show an icon in the room header for shared history ([#&#8203;31879](element-hq/element-web#31879)). Contributed by [@&#8203;richvdh](https://github.com/richvdh).
- Remove "history may be shared" banner. ([#&#8203;31881](element-hq/element-web#31881)). Contributed by [@&#8203;kaylendog](https://github.com/kaylendog).
- Allow dismissing 'Key storage out of sync' temporarily ([#&#8203;31455](element-hq/element-web#31455)). Contributed by [@&#8203;andybalaam](https://github.com/andybalaam).
- Add `resolutions` entry for `matrix-widget-api` to package.json ([#&#8203;31851](element-hq/element-web#31851)). Contributed by [@&#8203;toger5](https://github.com/toger5).
- Improve visibility under contrast control mode ([#&#8203;31847](element-hq/element-web#31847)). Contributed by [@&#8203;t3chguy](https://github.com/t3chguy).
- Unread Sorting - Add option for sorting in `OptionsMenuView` ([#&#8203;31754](element-hq/element-web#31754)). Contributed by [@&#8203;MidhunSureshR](https://github.com/MidhunSureshR).
- Unread sorting - Implement sorter and use it in the room list store ([#&#8203;31723](element-hq/element-web#31723)). Contributed by [@&#8203;MidhunSureshR](https://github.com/MidhunSureshR).
- Allow Element Call widgets to receive sticky events ([#&#8203;31843](element-hq/element-web#31843)). Contributed by [@&#8203;robintown](https://github.com/robintown).
- Improve icon rendering accessibility ([#&#8203;31791](element-hq/element-web#31791)). Contributed by [@&#8203;t3chguy](https://github.com/t3chguy).
- Add message preview toggle to room list header option ([#&#8203;31821](element-hq/element-web#31821)). Contributed by [@&#8203;florianduros](https://github.com/florianduros).

#### 🐛 Bug Fixes

- \[Backport staging] Fix room list not being cleared ([#&#8203;32438](element-hq/element-web#32438)). Contributed by [@&#8203;RiotRobot](https://github.com/RiotRobot).
- Fix failure to update room info panel on joinrule change ([#&#8203;31938](element-hq/element-web#31938)). Contributed by [@&#8203;richvdh](https://github.com/richvdh).
- Throttle space notification state calculation ([#&#8203;31922](element-hq/element-web#31922)). Contributed by [@&#8203;dbkr](https://github.com/dbkr).
- Fix emoji verification responsive layout ([#&#8203;31899](element-hq/element-web#31899)). Contributed by [@&#8203;t3chguy](https://github.com/t3chguy).
- Add patch for linkify to fix doctype handling ([#&#8203;31900](element-hq/element-web#31900)). Contributed by [@&#8203;dbkr](https://github.com/dbkr).
- Fix rooms with no messages appearing at the top of the room list ([#&#8203;31798](element-hq/element-web#31798)). Contributed by [@&#8203;MidhunSureshR](https://github.com/MidhunSureshR).
- Fix room list menu flashes when menu is closed ([#&#8203;31868](element-hq/element-web#31868)). Contributed by [@&#8203;florianduros](https://github.com/florianduros).
- Message preview toggle is inverted in room list header ([#&#8203;31865](element-hq/element-web#31865)). Contributed by [@&#8203;florianduros](https://github.com/florianduros).
- Fix duplicate toasts appearing for the same call if two events appear. ([#&#8203;31693](element-hq/element-web#31693)). Contributed by [@&#8203;Half-Shot](https://github.com/Half-Shot).
- Fix ability to send rageshake during session restore failure ([#&#8203;31848](element-hq/element-web#31848)). Contributed by [@&#8203;t3chguy](https://github.com/t3chguy).
- Fix mis-alignment of `Threads` right panel title ([#&#8203;31849](element-hq/element-web#31849)). Contributed by [@&#8203;t3chguy](https://github.com/t3chguy).
- Unset buttons does not include color inherit ([#&#8203;31801](element-hq/element-web#31801)). Contributed by [@&#8203;Philldomd](https://github.com/Philldomd).

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4zLjYiLCJ1cGRhdGVkSW5WZXIiOiI0My4zLjYiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsImltYWdlIl19-->

Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/3880
Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net>
Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rooms with no messages (due to retention rules) persist at the top of the roomlist

2 participants