Fix duplicate toasts appearing for the same call if two events appear. #31693

Half-Shot · 2026-01-09T15:03:19Z

We can follow the referenced event to find the true call ID, and de-duplicate upon that rather than the notification eventId which is obviously unique each time.

Checklist

I have read through review guidelines and CONTRIBUTING.md.
Tests written for new code (and old code if feasible).
New or updated public/exported symbols have accurate TSDoc documentation.
Linter and other CI checks pass.
I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Half-Shot · 2026-01-09T15:03:51Z

test/unit-tests/Notifier-test.ts

        beforeEach(() => {
-            jest.spyOn(SettingsStore, "getValue").mockReturnValue(true);
+            jest.spyOn(SettingsStore, "getValue").mockImplementation((key, ...params) => {
+                if (key === "notificationsEnabled") {


Flyby fix: jest.spyOn(SettingsStore, "getValue").mockReturnValue(true); is evil and not to be used.

playwright/e2e/voip/element-call.spec.ts

BillCarsonFr

I have some questions on the logic about getting the parent event

BillCarsonFr · 2026-01-13T08:28:44Z

src/Notifier.ts

+            const rtcSession = room && cli.matrixRTC.getRoomSession(room);
+            if (rtcSession?.slotDescription?.application == "m.call") {
+                // If we're already joined to the session, don't notify.
+                if (rtcSession.memberships.some((m) => m.userId === cli.getUserId())) {


I liked when this was extracted to a const with a good name ;)

Fix'd. I agree :)

src/Notifier.ts

BillCarsonFr · 2026-01-13T08:36:11Z

src/Notifier.ts

-                key: getIncomingCallToastKey(eventId, roomId),
+
+            const callMembership = room?.findEventById(getReferencedMembershipEventId);
+            if (!callMembership) {


So it tries to get the parent event, and if it is not there it just logs and silently continue?
Why trying to get it? Maybe it should use fetchRoomEvent?

I've done this just to catch the edge case. I suspect in 99.9999% of cases the client will have the call event before the notif as that's the sent order, and sync should be storing them in sequence. Just in case though there is now a call to fetchRoomEvent.

BillCarsonFr · 2026-01-13T08:36:30Z

src/Notifier.ts

+            // If we cannot determine the key, we'll accept it but assume it's empty string.
+            // This means if you have malformed notifications or call memberships your notifications
+            // will overwrite, but the solution to that is to use well-formed events.
+            const callId = callMembership?.getContent<SessionMembershipData>().call_id ?? "";


Can it be a left membership content?

it would be a bit weird to send a notif on for a left call membership?

butt call? Immedialty stopped :D

BillCarsonFr

Ok for me.
Maybe we want to create a separate issue to talk about handling of wild rtc notifications sent by misbehaving clients? not related to any membership? when no slots?

Half-Shot · 2026-01-13T11:30:19Z

Ok for me. Maybe we want to create a separate issue to talk about handling of wild rtc notifications sent by misbehaving clients? not related to any membership? when no slots?

Aye, let's do that.

src/toasts/IncomingCallToast.tsx

src/Notifier.ts

…880) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [element-hq/element-web](https://github.com/element-hq/element-web) | patch | `v1.12.9` → `v1.12.10` | --- ### Release Notes <details> <summary>element-hq/element-web (element-hq/element-web)</summary> ### [`v1.12.10`](https://github.com/element-hq/element-web/releases/tag/v1.12.10) [Compare Source](element-hq/element-web@v1.12.9...v1.12.10) #### ✨ Features - Support additional\_creators in /upgraderoom (MSC4289) ([#31934](element-hq/element-web#31934)). Contributed by [@andybalaam](https://github.com/andybalaam). - Update room header icon for world\_readable rooms ([#31915](element-hq/element-web#31915)). Contributed by [@richvdh](https://github.com/richvdh). - Show an icon in the room header for shared history ([#31879](element-hq/element-web#31879)). Contributed by [@richvdh](https://github.com/richvdh). - Remove "history may be shared" banner. ([#31881](element-hq/element-web#31881)). Contributed by [@kaylendog](https://github.com/kaylendog). - Allow dismissing 'Key storage out of sync' temporarily ([#31455](element-hq/element-web#31455)). Contributed by [@andybalaam](https://github.com/andybalaam). - Add `resolutions` entry for `matrix-widget-api` to package.json ([#31851](element-hq/element-web#31851)). Contributed by [@toger5](https://github.com/toger5). - Improve visibility under contrast control mode ([#31847](element-hq/element-web#31847)). Contributed by [@t3chguy](https://github.com/t3chguy). - Unread Sorting - Add option for sorting in `OptionsMenuView` ([#31754](element-hq/element-web#31754)). Contributed by [@MidhunSureshR](https://github.com/MidhunSureshR). - Unread sorting - Implement sorter and use it in the room list store ([#31723](element-hq/element-web#31723)). Contributed by [@MidhunSureshR](https://github.com/MidhunSureshR). - Allow Element Call widgets to receive sticky events ([#31843](element-hq/element-web#31843)). Contributed by [@robintown](https://github.com/robintown). - Improve icon rendering accessibility ([#31791](element-hq/element-web#31791)). Contributed by [@t3chguy](https://github.com/t3chguy). - Add message preview toggle to room list header option ([#31821](element-hq/element-web#31821)). Contributed by [@florianduros](https://github.com/florianduros). #### 🐛 Bug Fixes - \[Backport staging] Fix room list not being cleared ([#32438](element-hq/element-web#32438)). Contributed by [@RiotRobot](https://github.com/RiotRobot). - Fix failure to update room info panel on joinrule change ([#31938](element-hq/element-web#31938)). Contributed by [@richvdh](https://github.com/richvdh). - Throttle space notification state calculation ([#31922](element-hq/element-web#31922)). Contributed by [@dbkr](https://github.com/dbkr). - Fix emoji verification responsive layout ([#31899](element-hq/element-web#31899)). Contributed by [@t3chguy](https://github.com/t3chguy). - Add patch for linkify to fix doctype handling ([#31900](element-hq/element-web#31900)). Contributed by [@dbkr](https://github.com/dbkr). - Fix rooms with no messages appearing at the top of the room list ([#31798](element-hq/element-web#31798)). Contributed by [@MidhunSureshR](https://github.com/MidhunSureshR). - Fix room list menu flashes when menu is closed ([#31868](element-hq/element-web#31868)). Contributed by [@florianduros](https://github.com/florianduros). - Message preview toggle is inverted in room list header ([#31865](element-hq/element-web#31865)). Contributed by [@florianduros](https://github.com/florianduros). - Fix duplicate toasts appearing for the same call if two events appear. ([#31693](element-hq/element-web#31693)). Contributed by [@Half-Shot](https://github.com/Half-Shot). - Fix ability to send rageshake during session restore failure ([#31848](element-hq/element-web#31848)). Contributed by [@t3chguy](https://github.com/t3chguy). - Fix mis-alignment of `Threads` right panel title ([#31849](element-hq/element-web#31849)). Contributed by [@t3chguy](https://github.com/t3chguy). - Unset buttons does not include color inherit ([#31801](element-hq/element-web#31801)). Contributed by [@Philldomd](https://github.com/Philldomd). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/3880 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>

Half-Shot added 2 commits January 9, 2026 14:05

fix export

060ef91

Don't allow duplicate toasts.

938be39

Half-Shot requested review from a team and robintown and removed request for a team January 9, 2026 15:03

Half-Shot requested a review from a team as a code owner January 9, 2026 15:03

Half-Shot requested a review from florianduros January 9, 2026 15:03

Half-Shot added the T-Defect label Jan 9, 2026

Half-Shot commented Jan 9, 2026

View reviewed changes

fix imports

d8ea982

github-actions bot deployed to Netlify January 9, 2026 15:08 View deployment

fix

38e75f1

github-actions bot deployed to Netlify January 9, 2026 15:12 View deployment

github-actions bot deployed to EndToEndTests January 9, 2026 15:34 View deployment

fix rel_type to be m.reference in tests

1b7c375

Half-Shot requested a review from a team as a code owner January 12, 2026 11:09

github-actions bot deployed to Netlify January 12, 2026 11:13 View deployment

github-actions bot deployed to EndToEndTests January 12, 2026 11:27 View deployment

Half-Shot commented Jan 12, 2026

View reviewed changes

playwright/e2e/voip/element-call.spec.ts Show resolved Hide resolved

toger5 approved these changes Jan 12, 2026

View reviewed changes

BillCarsonFr requested changes Jan 13, 2026

View reviewed changes

Half-Shot added 3 commits January 13, 2026 11:13

Fix case where redactions were not longer checked.

7c36313

Ensure toastkey is calculated by the room call_id

d93d324

Ensure we fetch the call event if it does not exist locally.

9f7d75f

github-actions bot deployed to Netlify January 13, 2026 11:17 View deployment

BillCarsonFr approved these changes Jan 13, 2026

View reviewed changes

github-actions bot deployed to EndToEndTests January 13, 2026 11:29 View deployment

cleanup / reduce code complexity

0543030

github-actions bot deployed to Netlify January 13, 2026 11:52 View deployment

github-actions bot deployed to EndToEndTests January 13, 2026 12:05 View deployment

Merge branch 'develop' into hs/fix-duplicate-call-toasts

3003528

github-actions bot deployed to Netlify January 20, 2026 13:15 View deployment

github-actions bot deployed to EndToEndTests January 20, 2026 13:28 View deployment

florianduros approved these changes Jan 20, 2026

View reviewed changes

src/toasts/IncomingCallToast.tsx Show resolved Hide resolved

src/Notifier.ts Outdated Show resolved Hide resolved

src/Notifier.ts Show resolved Hide resolved

Half-Shot and others added 4 commits January 23, 2026 10:16

Add docs

691bcd5

Add comment

37ccbd4

merge condition

cda741f

Merge branch 'develop' into hs/fix-duplicate-call-toasts

8361d4e

Half-Shot enabled auto-merge January 23, 2026 10:20

github-actions bot deployed to Netlify January 23, 2026 10:23 View deployment

Half-Shot added this pull request to the merge queue Jan 23, 2026

github-actions bot deployed to EndToEndTests January 23, 2026 10:38 View deployment

Merged via the queue into develop with commit c135c16 Jan 23, 2026
37 checks passed

Half-Shot deleted the hs/fix-duplicate-call-toasts branch January 23, 2026 10:57

Uh oh!

Fix duplicate toasts appearing for the same call if two events appear. #31693

Fix duplicate toasts appearing for the same call if two events appear. #31693

Conversation

Half-Shot commented Jan 9, 2026

Checklist

Uh oh!

Half-Shot Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BillCarsonFr left a comment

Choose a reason for hiding this comment

Uh oh!

BillCarsonFr Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Half-Shot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BillCarsonFr Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Half-Shot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

BillCarsonFr Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Half-Shot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

BillCarsonFr Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BillCarsonFr left a comment

Choose a reason for hiding this comment

Uh oh!

Half-Shot commented Jan 13, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Half-Shot Jan 9, 2026 •

edited

Loading

BillCarsonFr Jan 13, 2026 •

edited

Loading