Update algorithm for history visible banner.#31577
Merged
kaylendog merged 5 commits intoelement-hq:developfrom Dec 19, 2025
Merged
Update algorithm for history visible banner.#31577kaylendog merged 5 commits intoelement-hq:developfrom
kaylendog merged 5 commits intoelement-hq:developfrom
Conversation
- The banner now only shows for rooms with `shared` or `worldReadable` history visibility. - The banner does not show in rooms in which the current user cannot send messages.
Comment on lines
92
to
98
| visible: | ||
| featureEnabled && | ||
| canSendMessages && | ||
| !threadId && | ||
| room.hasEncryptionStateEvent() && | ||
| room.getHistoryVisibility() !== HistoryVisibility.Joined && | ||
| isHistoryVisible && | ||
| !acknowledged, |
Member
There was a problem hiding this comment.
Documentation about visible is welcomed, there is a lot of checks here
Contributor
Author
There was a problem hiding this comment.
Added a comment above detailing why each term is in the conjunction - might be a bit excessive? 1ab3184
Member
There was a problem hiding this comment.
this file shoudn't be committed
Contributor
Author
There was a problem hiding this comment.
Fixed in 1df66d6. Wondering if this should be in .gitignore?
Co-authored-by: Florian Duros <florian.duros@ormaz.fr>
florianduros
approved these changes
Dec 19, 2025
3 tasks
kaylendog
added a commit
that referenced
this pull request
Jan 26, 2026
This reverts commit ce9c66b.
kaylendog
added a commit
that referenced
this pull request
Jan 26, 2026
This reverts commit ce9c66b.
kaylendog
added a commit
that referenced
this pull request
Jan 26, 2026
This reverts commit ce9c66b.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 27, 2026
* Revert "Update algorithm for history visible banner. (#31577)" This reverts commit ce9c66b. * Revert "Update prop type & documentation for HistoryVisibleBanner and VM. (#31545)" This reverts commit 4da149e. * Revert "Prevent history visible banner from displaying in threads. (#31535)" This reverts commit c7134e8. * Revert "Implement UI for history visibility acknowledgement. (#31156)" This reverts commit cff9119.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sharedorworldReadablehistory visibility.Checklist
public/exportedsymbols have accurate TSDoc documentation.